IB/qib: Delete struct qib_ivdev.qp_rnd (3e87f431) · Commits · 戴 / test

I was checking the field to see if it needed the full get_random_bytes() and discovered it's unused. Only compile-tested, as I don't have the hardware, but I'm still pretty confident. Link: https://lore.kernel.org/r/202003281643.02SGh6eG002694@sdf.org Signed-off-by:

George Spelvin <lkml@sdf.org> Signed-off-by:

Jason Gunthorpe <jgg@mellanox.com>

drivers/infiniband/hw/qib/qib_verbs.c

+0 −2

Original line number	Diff line number	Diff line
		@@ -39,7 +39,6 @@
		#include <linux/utsname.h>
		#include <linux/rculist.h>
		#include <linux/mm.h>
		#include <linux/random.h>
		#include <linux/vmalloc.h>
		#include <rdma/rdma_vt.h>

		@@ -1503,7 +1502,6 @@ int qib_register_ib_device(struct qib_devdata *dd)
		unsigned i, ctxt;
		int ret;

		get_random_bytes(&dev->qp_rnd, sizeof(dev->qp_rnd));
		for (i = 0; i < dd->num_pports; i++)
		init_ibport(ppd + i);

drivers/infiniband/hw/qib/qib_verbs.h

+0 −1

Original line number	Diff line number	Diff line
		@@ -177,7 +177,6 @@ struct qib_ibdev {
		struct timer_list mem_timer;
		struct qib_pio_header *pio_hdrs;
		dma_addr_t pio_hdrs_phys;
		u32 qp_rnd; /* random bytes for hash */

		u32 n_piowait;
		u32 n_txwait;

Admin message