Commit 3e7cf902 authored Jan 21, 2015 by Wu Fengguang Committed by Ulf Hansson Jan 21, 2015

mmc: sdhci: host: fix odd_ptr_err.cocci warnings



drivers/mmc/host/sdhci_f_sdh30.c:143:5-11: inconsistent IS_ERR and PTR_ERR, PTR_ERR on line 144

 PTR_ERR should access the value just tested by IS_ERR

Semantic patch information:
 There can be false positives in the patch case, where it is the call
 IS_ERR that is wrong.

Generated by: scripts/coccinelle/tests/odd_ptr_err.cocci

CC: Vincent Yang <vincent.yang.fujitsu@gmail.com>
Signed-off-by: Fengguang Wu <fengguang.wu@intel.com>
Signed-off-by: Ulf Hansson <ulf.hansson@linaro.org>

parent 6bb836d6

drivers/mmc/host/sdhci_f_sdh30.c

+1 −1

Original line number	Diff line number	Diff line
		@@ -141,7 +141,7 @@ static int sdhci_f_sdh30_probe(struct platform_device *pdev)
		res = platform_get_resource(pdev, IORESOURCE_MEM, 0);
		host->ioaddr = devm_ioremap_resource(&pdev->dev, res);
		if (IS_ERR(host->ioaddr)) {
		ret = PTR_ERR(host);
		ret = PTR_ERR(host->ioaddr);
		goto err;
		}

Admin message