Commit 3e798068 authored Dec 11, 2017 by Nikolay Borisov Committed by David Sterba Jan 22, 2018

btrfs: Remove pair of bio_get/put in btrfs_schedule_bio



This code was added in 492bb6de ("Btrfs: Hold a reference on bios
during submit_bio, add some extra bio checks"). However, holding a
reference on a bio is necessary only if it's going to be referenced
after the submit_bio returns and the bio is completed. In this
particular instance this is not the case so there is no need to hold
an extra reference since we directly return.

Signed-off-by: Nikolay Borisov <nborisov@suse.com>
Reviewed-by: Liu Bo <bo.li.liu@oracle.com>
Signed-off-by: David Sterba <dsterba@suse.com>

parent 9ea2c7c9

fs/btrfs/volumes.c

+0 −2

Original line number	Diff line number	Diff line
		@@ -6132,9 +6132,7 @@ static noinline void btrfs_schedule_bio(struct btrfs_device *device,

		/* don't bother with additional async steps for reads, right now */
		if (bio_op(bio) == REQ_OP_READ) {
		bio_get(bio);
		btrfsic_submit_bio(bio);
		bio_put(bio);
		return;
		}

Admin message