Commit 3e62af82 authored by Uwe Kleine-König's avatar Uwe Kleine-König Committed by Shawn Guo
Browse files

ARM: imx: select USE_OF 



Commit

      544496ab (ARM: imx: move irq_domain_add_legacy call into avic driver)

introduced unconditional calls to irq_find_mapping and
irq_domain_add_legacy, but it's still possible to have a .config without
CONFIG_IRQ_DOMAIN=y resulting in

	  CC      arch/arm/plat-mxc/avic.o
	arch/arm/plat-mxc/avic.c: In function 'avic_handle_irq':
	arch/arm/plat-mxc/avic.c:172: error: implicit declaration of function 'irq_find_mapping'
	arch/arm/plat-mxc/avic.c: In function 'mxc_init_irq':
	arch/arm/plat-mxc/avic.c:207: error: implicit declaration of function 'irq_domain_add_legacy'
	arch/arm/plat-mxc/avic.c:208: error: 'irq_domain_simple_ops' undeclared (first use in this function)
	arch/arm/plat-mxc/avic.c:208: error: (Each undeclared identifier is reported only once
	arch/arm/plat-mxc/avic.c:208: error: for each function it appears in.)
	arch/arm/plat-mxc/avic.c:208: warning: assignment makes pointer from integer without a cast
	make[3]: *** [arch/arm/plat-mxc/avic.o] Error 1
	make[2]: *** [arch/arm/plat-mxc/avic.o] Error 2
	make[1]: *** [sub-make] Error 2
	make: *** [all] Error 2

While selecting CONFIG_IRQ_DOMAIN would be enough, USE_OF is the future
and implies CONFIG_IRQ_DOMAIN. So select USE_OF for ARCH_MXC and drop
other explicit selects that are superflous now.

Signed-off-by: default avatarUwe Kleine-König <u.kleine-koenig@pengutronix.de>
Signed-off-by: default avatarShawn Guo <shawn.guo@linaro.org>
parent 6684294d

arch/arm/Kconfig

+1 −0
Original line number Original line Diff line number Diff line
@@ -447,6 +447,7 @@ config ARCH_MXC 
	select GENERIC_IRQ_CHIP

	select GENERIC_IRQ_CHIP

	select MULTI_IRQ_HANDLER

	select MULTI_IRQ_HANDLER

	select SPARSE_IRQ

	select SPARSE_IRQ

	select USE_OF

	help

	help

	  Support for Freescale MXC/iMX-based family of processors

	  Support for Freescale MXC/iMX-based family of processors

arch/arm/mach-imx/Kconfig

+0 −4
Original line number Original line Diff line number Diff line
@@ -380,7 +380,6 @@ config MACH_IMX27IPCAM 
config MACH_IMX27_DT

config MACH_IMX27_DT

	bool "Support i.MX27 platforms from device tree"

	bool "Support i.MX27 platforms from device tree"

	select SOC_IMX27

	select SOC_IMX27

	select USE_OF

	help

	help

	  Include support for Freescale i.MX27 based platforms

	  Include support for Freescale i.MX27 based platforms

	  using the device tree for discovery

	  using the device tree for discovery
@@ -662,7 +661,6 @@ comment "i.MX51 machines:" 
config MACH_IMX51_DT

config MACH_IMX51_DT

	bool "Support i.MX51 platforms from device tree"

	bool "Support i.MX51 platforms from device tree"

	select SOC_IMX51

	select SOC_IMX51

	select USE_OF

	select MACH_MX51_BABBAGE

	select MACH_MX51_BABBAGE

	help

	help

	  Include support for Freescale i.MX51 based platforms

	  Include support for Freescale i.MX51 based platforms
@@ -758,7 +756,6 @@ comment "i.MX53 machines:" 
config MACH_IMX53_DT

config MACH_IMX53_DT

	bool "Support i.MX53 platforms from device tree"

	bool "Support i.MX53 platforms from device tree"

	select SOC_IMX53

	select SOC_IMX53

	select USE_OF

	select MACH_MX53_ARD

	select MACH_MX53_ARD

	select MACH_MX53_EVK

	select MACH_MX53_EVK

	select MACH_MX53_LOCO

	select MACH_MX53_LOCO
@@ -831,7 +828,6 @@ config SOC_IMX6Q 
	select HAVE_SMP

	select HAVE_SMP

	select PINCTRL

	select PINCTRL

	select PINCTRL_IMX6Q

	select PINCTRL_IMX6Q

	select USE_OF





	help

	help

	  This enables support for Freescale i.MX6 Quad processor.

	  This enables support for Freescale i.MX6 Quad processor.

CRA Git | Maintained and supported by SUSTech CRA and CCSE