Commit 3e5ebcdd authored Mar 01, 2019 by José Roberto de Souza

drm/i915: Don't manually add connectors and planes state



drm_atomic_commit() call chain already takes care of adding
connectors and planes, so lets no add then manually if not changing
their states.

drm_atomic_commit()
        drm_atomic_check_only()
                config->funcs->atomic_check()/intel_atomic_check()
                        drm_atomic_helper_check()
                                drm_atomic_helper_check_modeset()
                                        for_each_oldnew_crtc_in_state()
                                                drm_atomic_add_affected_connectors()
                                                drm_atomic_add_affected_planes()

Reviewed-by: Ville Syrjälä <ville.syrjala@linux.intel.com>
Cc: Ville Syrjälä <ville.syrjala@linux.intel.com>
Cc: Lyude Paul <lyude@redhat.com>
Signed-off-by: José Roberto de Souza <jose.souza@intel.com>
Link: https://patchwork.freedesktop.org/patch/msgid/20190302003349.19189-2-jose.souza@intel.com

parent a551cd66

drivers/gpu/drm/i915/intel_ddi.c

+0 −8

Original line number	Diff line number	Diff line
		@@ -3975,14 +3975,6 @@ static int modeset_pipe(struct drm_crtc *crtc,

		crtc_state->mode_changed = true;

		ret = drm_atomic_add_affected_connectors(state, crtc);
		if (ret)
		goto out;

		ret = drm_atomic_add_affected_planes(state, crtc);
		if (ret)
		goto out;

		ret = drm_atomic_commit(state);
		out:
		drm_atomic_state_put(state);

Admin message