Commit 3e3e406e authored by Lucas Stach's avatar Lucas Stach Committed by Bjorn Helgaas
Browse files

PCI: imx6: Put LTSSM in "Detect" state before disabling it 

This fixes a boot hang observed when the bootloader already enabled the
PCIe link for its own use.  The fundamental problem is that Freescale
forgot to wire up the core reset, so software doesn't have a sane way to
get the core into a defined state.

According to the DW PCIe core reference manual, configuration of the core
may only happen when the LTSSM is disabled, so this is one of the first
things we need to do.  Apparently this isn't safe to do when the LTSSM is in
any state other than "detect" as we observe an instant machine hang when
trying to do so while the link is already up.

As a workaround, force LTSSM into detect state right before hitting the
disable switch.  There is still a race window because the LTSSM may
transition out of "detect" before we can disable it, but it's the best
we can do for now.

[bhelgaas: mention race window]
Link: http://lkml.kernel.org/r/1406830565-23450-3-git-send-email-l.stach@pengutronix.de


Reported-by: default avatarFabio Estevam <fabio.estevam@freescale.com>
Signed-off-by: default avatarLucas Stach <l.stach@pengutronix.de>
Signed-off-by: default avatarBjorn Helgaas <bhelgaas@google.com>
Acked-by: default avatarTim Harvey <tharvey@gateworks.com>
parent 1ba55f55

drivers/pci/host/pci-imx6.c

+38 −0
Original line number Diff line number Diff line
@@ -49,6 +49,9 @@ struct imx6_pcie { 


/* PCIe Port Logic registers (memory-mapped) */

#define PL_OFFSET 0x700

#define PCIE_PL_PFLR (PL_OFFSET + 0x08)

#define PCIE_PL_PFLR_LINK_STATE_MASK		(0x3f << 16)

#define PCIE_PL_PFLR_FORCE_LINK			(1 << 15)

#define PCIE_PHY_DEBUG_R0 (PL_OFFSET + 0x28)

#define PCIE_PHY_DEBUG_R1 (PL_OFFSET + 0x2c)

#define PCIE_PHY_DEBUG_R1_XMLH_LINK_IN_TRAINING	(1 << 29)
@@ -214,6 +217,32 @@ static int imx6q_pcie_abort_handler(unsigned long addr, 
static int imx6_pcie_assert_core_reset(struct pcie_port *pp)

{

	struct imx6_pcie *imx6_pcie = to_imx6_pcie(pp);

	u32 val, gpr1, gpr12;



	/*

	 * If the bootloader already enabled the link we need some special

	 * handling to get the core back into a state where it is safe to

	 * touch it for configuration.  As there is no dedicated reset signal

	 * wired up for MX6QDL, we need to manually force LTSSM into "detect"

	 * state before completely disabling LTSSM, which is a prerequisite

	 * for core configuration.

	 *

	 * If both LTSSM_ENABLE and REF_SSP_ENABLE are active we have a strong

	 * indication that the bootloader activated the link.

	 */

	regmap_read(imx6_pcie->iomuxc_gpr, IOMUXC_GPR1, &gpr1);

	regmap_read(imx6_pcie->iomuxc_gpr, IOMUXC_GPR12, &gpr12);



	if ((gpr1 & IMX6Q_GPR1_PCIE_REF_CLK_EN) &&

	    (gpr12 & IMX6Q_GPR12_PCIE_CTL_2)) {

		val = readl(pp->dbi_base + PCIE_PL_PFLR);

		val &= ~PCIE_PL_PFLR_LINK_STATE_MASK;

		val |= PCIE_PL_PFLR_FORCE_LINK;

		writel(val, pp->dbi_base + PCIE_PL_PFLR);



		regmap_update_bits(imx6_pcie->iomuxc_gpr, IOMUXC_GPR12,

				IMX6Q_GPR12_PCIE_CTL_2, 0 << 10);

	}



	regmap_update_bits(imx6_pcie->iomuxc_gpr, IOMUXC_GPR1,

			IMX6Q_GPR1_PCIE_TEST_PD, 1 << 18);
@@ -589,6 +618,14 @@ static int __init imx6_pcie_probe(struct platform_device *pdev) 
	return 0;

}



static void imx6_pcie_shutdown(struct platform_device *pdev)

{

	struct imx6_pcie *imx6_pcie = platform_get_drvdata(pdev);



	/* bring down link, so bootloader gets clean state in case of reboot */

	imx6_pcie_assert_core_reset(&imx6_pcie->pp);

}



static const struct of_device_id imx6_pcie_of_match[] = {

	{ .compatible = "fsl,imx6q-pcie", },

	{},
@@ -601,6 +638,7 @@ static struct platform_driver imx6_pcie_driver = { 
		.owner	= THIS_MODULE,

		.of_match_table = imx6_pcie_of_match,

	},

	.shutdown = imx6_pcie_shutdown,

};



/* Freescale PCIe driver does not allow module unload */

CRA Git | Maintained and supported by SUSTech CRA and CCSE