Commit 3e2cd91a authored Sep 20, 2014 by Zefan Li Committed by Tejun Heo Sep 20, 2014

cgroup: fix missing unlock in cgroup_release_agent()



The patch 971ff493: "cgroup: use a per-cgroup work for release
agent" from Sep 18, 2014, leads to the following static checker
warning:

	kernel/cgroup.c:5310 cgroup_release_agent()
	warn: 'mutex:&cgroup_mutex' is sometimes locked here and sometimes unlocked.

Reported-by: Dan Carpenter <dan.carpenter@oracle.com>
Signed-off-by: Zefan Li <lizefan@huawei.com>
Signed-off-by: Tejun Heo <tj@kernel.org>

parent a25eb52e

kernel/cgroup.c

+3 −0

Original line number	Original line	Diff line number	Diff line
	@@ -5291,7 +5291,10 @@ static void cgroup_release_agent(struct work_struct *work)

	mutex_unlock(&cgroup_mutex);		mutex_unlock(&cgroup_mutex);
	call_usermodehelper(argv[0], argv, envp, UMH_WAIT_EXEC);		call_usermodehelper(argv[0], argv, envp, UMH_WAIT_EXEC);
			goto out_free;
	out:		out:
			mutex_unlock(&cgroup_mutex);
			out_free:
	kfree(agentbuf);		kfree(agentbuf);
	kfree(pathbuf);		kfree(pathbuf);
	}		}

Admin message