Commit 3e146753 authored by Rob Herring's avatar Rob Herring Committed by Bjorn Helgaas
Browse files

PCI: Kill off set_irq_flags() usage 



set_irq_flags is ARM-specific with custom flags which have genirq
equivalents.  Convert drivers to use the genirq interfaces directly, so we
can kill off set_irq_flags.  The translation of flags is as follows:

  IRQF_VALID -> !IRQ_NOREQUEST
  IRQF_PROBE -> !IRQ_NOPROBE
  IRQF_NOAUTOEN -> IRQ_NOAUTOEN

For IRQs managed by an irqdomain, the irqdomain core code handles clearing
and setting IRQ_NOREQUEST already, so there is no need to do this in .map()
functions, and we can simply remove the set_irq_flags calls.  Some users
also modify IRQ_NOPROBE, and this has been maintained although it is not
clear that is really needed.  There appears to be a great deal of blind
copy and paste of this code.

Signed-off-by: default avatarRob Herring <robh@kernel.org>
Signed-off-by: default avatarBjorn Helgaas <bhelgaas@google.com>
Acked-by: default avatarJingoo Han <jingoohan1@gmail.com>
CC: Kishon Vijay Abraham I <kishon@ti.com>
CC: Murali Karicheri <m-karicheri2@ti.com>
CC: Thierry Reding <thierry.reding@gmail.com>
CC: Stephen Warren <swarren@wwwdotorg.org>
CC: Alexandre Courbot <gnurou@gmail.com>
CC: Jingoo Han <jingoohan1@gmail.com>
CC: Pratyush Anand <pratyush.anand@gmail.com>
CC: Simon Horman <horms@verge.net.au>
CC: Michal Simek <michal.simek@xilinx.com>
CC: "Sören Brinkmann" <soren.brinkmann@xilinx.com>
parent 5f226991

drivers/pci/host/pci-dra7xx.c

+0 −1
Original line number Diff line number Diff line
@@ -155,7 +155,6 @@ static int dra7xx_pcie_intx_map(struct irq_domain *domain, unsigned int irq, 
{

	irq_set_chip_and_handler(irq, &dummy_irq_chip, handle_simple_irq);

	irq_set_chip_data(irq, domain->host_data);

	set_irq_flags(irq, IRQF_VALID);



	return 0;

}

drivers/pci/host/pci-keystone-dw.c

+0 −2
Original line number Diff line number Diff line
@@ -196,7 +196,6 @@ static int ks_dw_pcie_msi_map(struct irq_domain *domain, unsigned int irq, 
	irq_set_chip_and_handler(irq, &ks_dw_pcie_msi_irq_chip,

				 handle_level_irq);

	irq_set_chip_data(irq, domain->host_data);

	set_irq_flags(irq, IRQF_VALID);



	return 0;

}
@@ -277,7 +276,6 @@ static int ks_dw_pcie_init_legacy_irq_map(struct irq_domain *d, 
	irq_set_chip_and_handler(irq, &ks_dw_pcie_legacy_irq_chip,

				 handle_level_irq);

	irq_set_chip_data(irq, d->host_data);

	set_irq_flags(irq, IRQF_VALID);



	return 0;

}

drivers/pci/host/pci-tegra.c

+0 −1
Original line number Diff line number Diff line
@@ -1248,7 +1248,6 @@ static int tegra_msi_map(struct irq_domain *domain, unsigned int irq, 
{

	irq_set_chip_and_handler(irq, &tegra_msi_irq_chip, handle_simple_irq);

	irq_set_chip_data(irq, domain->host_data);

	set_irq_flags(irq, IRQF_VALID);



	tegra_cpuidle_pcie_irqs_in_use();

drivers/pci/host/pci-xgene-msi.c

+0 −1
Original line number Diff line number Diff line
@@ -223,7 +223,6 @@ static int xgene_irq_domain_alloc(struct irq_domain *domain, unsigned int virq, 
	irq_domain_set_info(domain, virq, msi_irq,

			    &xgene_msi_bottom_irq_chip, domain->host_data,

			    handle_simple_irq, NULL, NULL);

	set_irq_flags(virq, IRQF_VALID);



	return 0;

}

drivers/pci/host/pcie-designware.c

+0 −1
Original line number Diff line number Diff line
@@ -350,7 +350,6 @@ static int dw_pcie_msi_map(struct irq_domain *domain, unsigned int irq, 
{

	irq_set_chip_and_handler(irq, &dw_msi_irq_chip, handle_simple_irq);

	irq_set_chip_data(irq, domain->host_data);

	set_irq_flags(irq, IRQF_VALID);



	return 0;

}

CRA Git | Maintained and supported by SUSTech CRA and CCSE