Commit 3e14462f authored Apr 24, 2020 by Yang Yingliang Committed by David S. Miller Apr 25, 2020

ptp: clockmatrix: remove unnecessary comparison



The type of loaddr is u8 which is always '<=' 0xff, so the
loaddr <= 0xff is always true, we can remove this comparison.

Reported-by: Hulk Robot <hulkci@huawei.com>
Signed-off-by: Yang Yingliang <yangyingliang@huawei.com>
Reviewed-by: Vincent Cheng <vincent.cheng.xh@renesas.com>
Signed-off-by: David S. Miller <davem@davemloft.net>

parent f30e4720

drivers/ptp/ptp_clockmatrix.c

+1 −1

Original line number	Diff line number	Diff line
		@@ -780,7 +780,7 @@ static int idtcm_load_firmware(struct idtcm *idtcm,

		/* Page size 128, last 4 bytes of page skipped */
		if (((loaddr > 0x7b) && (loaddr <= 0x7f))
		\|\| ((loaddr > 0xfb) && (loaddr <= 0xff)))
		\|\| loaddr > 0xfb)
		continue;

		err = idtcm_write(idtcm, regaddr, 0, &val, sizeof(val));

Admin message