Commit 3de3c478 authored Sep 20, 2020 by Julia Lawall Committed by Jason Gunthorpe Sep 22, 2020

RDMA/efa: Drop double zeroing for sg_init_table()

sg_init_table() zeroes its first argument, so the allocation of that
argument doesn't have to.

The semantic patch that makes this change is as follows:
(http://coccinelle.lip6.fr/)

// <smpl>
@@
expression x,n,flags;
@@

x =
- kcalloc
+ kmalloc_array
  (n,sizeof(*x),flags)
...
sg_init_table(x,n)
// </smpl>

Link: https://lore.kernel.org/r/1600601186-7420-6-git-send-email-Julia.Lawall@inria.fr


Signed-off-by: Julia Lawall <Julia.Lawall@inria.fr>
Acked-by: Gal Pressman <galpress@amazon.com>
Signed-off-by: Jason Gunthorpe <jgg@nvidia.com>

parent f2334964

drivers/infiniband/hw/efa/efa_verbs.c

+1 −1

Original line number	Diff line number	Diff line
		@@ -1165,7 +1165,7 @@ static struct scatterlist efa_vmalloc_buf_to_sg(u64 buf, int page_cnt)
		struct page *pg;
		int i;

		sglist = kcalloc(page_cnt, sizeof(*sglist), GFP_KERNEL);
		sglist = kmalloc_array(page_cnt, sizeof(*sglist), GFP_KERNEL);
		if (!sglist)
		return NULL;
		sg_init_table(sglist, page_cnt);

Admin message