Commit 3dd1c9a1 authored Jul 23, 2018 by Paolo Abeni Committed by David S. Miller Jul 23, 2018

ip: hash fragments consistently



The skb hash for locally generated ip[v6] fragments belonging
to the same datagram can vary in several circumstances:
* for connected UDP[v6] sockets, the first fragment get its hash
  via set_owner_w()/skb_set_hash_from_sk()
* for unconnected IPv6 UDPv6 sockets, the first fragment can get
  its hash via ip6_make_flowlabel()/skb_get_hash_flowi6(), if
  auto_flowlabel is enabled

For the following frags the hash is usually computed via
skb_get_hash().
The above can cause OoO for unconnected IPv6 UDPv6 socket: in that
scenario the egress tx queue can be selected on a per packet basis
via the skb hash.
It may also fool flow-oriented schedulers to place fragments belonging
to the same datagram in different flows.

Fix the issue by copying the skb hash from the head frag into
the others at fragmentation time.

Before this commit:
perf probe -a "dev_queue_xmit skb skb->hash skb->l4_hash:b1@0/8 skb->sw_hash:b1@1/8"
netperf -H $IPV4 -t UDP_STREAM -l 5 -- -m 2000 -n &
perf record -e probe:dev_queue_xmit -e probe:skb_set_owner_w -a sleep 0.1
perf script
probe:dev_queue_xmit: (ffffffff8c6b1b20) hash=3713014309 l4_hash=1 sw_hash=0
probe:dev_queue_xmit: (ffffffff8c6b1b20) hash=0 l4_hash=0 sw_hash=0

After this commit:
probe:dev_queue_xmit: (ffffffff8c6b1b20) hash=2171763177 l4_hash=1 sw_hash=0
probe:dev_queue_xmit: (ffffffff8c6b1b20) hash=2171763177 l4_hash=1 sw_hash=0

Fixes: b73c3d0e ("net: Save TX flow hash in sock and set in skbuf on xmit")
Fixes: 67800f9b ("ipv6: Call skb_get_hash_flowi6 to get skb->hash in ip6_make_flowlabel")
Signed-off-by: Paolo Abeni <pabeni@redhat.com>
Reviewed-by: Eric Dumazet <edumazet@google.com>
Signed-off-by: David S. Miller <davem@davemloft.net>

parent e873e4b9

net/ipv4/ip_output.c

+2 −0

Original line number	Diff line number	Diff line
		@@ -523,6 +523,8 @@ static void ip_copy_metadata(struct sk_buff to, struct sk_buff from)
		to->dev = from->dev;
		to->mark = from->mark;

		skb_copy_hash(to, from);

		/* Copy the flags to each fragment. */
		IPCB(to)->flags = IPCB(from)->flags;

net/ipv6/ip6_output.c

+2 −0

Original line number	Diff line number	Diff line
		@@ -570,6 +570,8 @@ static void ip6_copy_metadata(struct sk_buff to, struct sk_buff from)
		to->dev = from->dev;
		to->mark = from->mark;

		skb_copy_hash(to, from);

		#ifdef CONFIG_NET_SCHED
		to->tc_index = from->tc_index;
		#endif

Admin message