Commit 3dcf4f20 authored by Michal Wajdeczko's avatar Michal Wajdeczko Committed by Jani Nikula
Browse files

drm/i915: Extend private i915_param_named macro with description 



We're always specifying description of each module param in
separate macro. Let's combine description into our main macro.
Started with Coccinelle, followed by minor cleanup.

@match1@
declarer name MODULE_PARM_DESC;
identifier n;
constant c;
@@
(
-	MODULE_PARM_DESC(n, c);
)

@fix1 depends on match1@
declarer name i915_param_named;
declarer name i915_param_named_unsafe;
identifier match1.n;
constant match1.c;
@@
(
	i915_param_named(n, ...
+	, c
	);
|
	i915_param_named_unsafe(n, ...
+	, c
	);
)

Suggested-by: default avatarJani Nikula <jani.nikula@intel.com>
Signed-off-by: default avatarMichal Wajdeczko <michal.wajdeczko@intel.com>
Cc: Jani Nikula <jani.nikula@intel.com>
Cc: Chris Wilson <chris@chris-wilson.co.uk>
Reviewed-by: default avatarChris Wilson <chris@chris-wilson.co.uk>
Signed-off-by: default avatarJani Nikula <jani.nikula@intel.com>
Link: https://patchwork.freedesktop.org/patch/msgid/20170914150805.28376-4-michal.wajdeczko@intel.com
parent c9546932

drivers/gpu/drm/i915/i915_params.c

+67 −100
Original line number Diff line number Diff line
@@ -25,10 +25,12 @@ 
#include "i915_params.h"

#include "i915_drv.h"



#define i915_param_named(name, T, perm) \

	module_param_named(name, i915.name, T, perm)

#define i915_param_named_unsafe(name, T, perm) \

	module_param_named_unsafe(name, i915.name, T, perm)

#define i915_param_named(name, T, perm, desc) \

	module_param_named(name, i915.name, T, perm); \

	MODULE_PARM_DESC(name, desc)

#define i915_param_named_unsafe(name, T, perm, desc) \

	module_param_named_unsafe(name, i915.name, T, perm); \

	MODULE_PARM_DESC(name, desc)



struct i915_params i915 __read_mostly = {

	.modeset = -1,
@@ -72,193 +74,158 @@ struct i915_params i915 __read_mostly = { 
	.enable_gvt = false,

};



i915_param_named(modeset, int, 0400);

MODULE_PARM_DESC(modeset,

i915_param_named(modeset, int, 0400,

	"Use kernel modesetting [KMS] (0=disable, "

	"1=on, -1=force vga console preference [default])");



i915_param_named_unsafe(panel_ignore_lid, int, 0600);

MODULE_PARM_DESC(panel_ignore_lid,

i915_param_named_unsafe(panel_ignore_lid, int, 0600,

	"Override lid status (0=autodetect, 1=autodetect disabled [default], "

	"-1=force lid closed, -2=force lid open)");



i915_param_named_unsafe(semaphores, int, 0400);

MODULE_PARM_DESC(semaphores,

i915_param_named_unsafe(semaphores, int, 0400,

	"Use semaphores for inter-ring sync "

	"(default: -1 (use per-chip defaults))");



i915_param_named_unsafe(enable_rc6, int, 0400);

MODULE_PARM_DESC(enable_rc6,

i915_param_named_unsafe(enable_rc6, int, 0400,

	"Enable power-saving render C-state 6. "

	"Different stages can be selected via bitmask values "

	"(0 = disable; 1 = enable rc6; 2 = enable deep rc6; 4 = enable deepest rc6). "

	"For example, 3 would enable rc6 and deep rc6, and 7 would enable everything. "

	"default: -1 (use per-chip default)");



i915_param_named_unsafe(enable_dc, int, 0400);

MODULE_PARM_DESC(enable_dc,

i915_param_named_unsafe(enable_dc, int, 0400,

	"Enable power-saving display C-states. "

	"(-1=auto [default]; 0=disable; 1=up to DC5; 2=up to DC6)");



i915_param_named_unsafe(enable_fbc, int, 0600);

MODULE_PARM_DESC(enable_fbc,

i915_param_named_unsafe(enable_fbc, int, 0600,

	"Enable frame buffer compression for power savings "

	"(default: -1 (use per-chip default))");



i915_param_named_unsafe(lvds_channel_mode, int, 0400);

MODULE_PARM_DESC(lvds_channel_mode,

i915_param_named_unsafe(lvds_channel_mode, int, 0400,

	 "Specify LVDS channel mode "

	 "(0=probe BIOS [default], 1=single-channel, 2=dual-channel)");



i915_param_named_unsafe(panel_use_ssc, int, 0600);

MODULE_PARM_DESC(panel_use_ssc,

i915_param_named_unsafe(panel_use_ssc, int, 0600,

	"Use Spread Spectrum Clock with panels [LVDS/eDP] "

	"(default: auto from VBT)");



i915_param_named_unsafe(vbt_sdvo_panel_type, int, 0400);

MODULE_PARM_DESC(vbt_sdvo_panel_type,

i915_param_named_unsafe(vbt_sdvo_panel_type, int, 0400,

	"Override/Ignore selection of SDVO panel mode in the VBT "

	"(-2=ignore, -1=auto [default], index in VBT BIOS table)");



i915_param_named_unsafe(reset, int, 0600);

MODULE_PARM_DESC(reset, "Attempt GPU resets (0=disabled, 1=full gpu reset, 2=engine reset [default])");

i915_param_named_unsafe(reset, int, 0600,

	"Attempt GPU resets (0=disabled, 1=full gpu reset, 2=engine reset [default])");



i915_param_named_unsafe(vbt_firmware, charp, 0400);

MODULE_PARM_DESC(vbt_firmware,

i915_param_named_unsafe(vbt_firmware, charp, 0400,

	"Load VBT from specified file under /lib/firmware");



#if IS_ENABLED(CONFIG_DRM_I915_CAPTURE_ERROR)

i915_param_named(error_capture, bool, 0600);

MODULE_PARM_DESC(error_capture,

i915_param_named(error_capture, bool, 0600,

	"Record the GPU state following a hang. "

	"This information in /sys/class/drm/card<N>/error is vital for "

	"triaging and debugging hangs.");

#endif



i915_param_named_unsafe(enable_hangcheck, bool, 0644);

MODULE_PARM_DESC(enable_hangcheck,

i915_param_named_unsafe(enable_hangcheck, bool, 0644,

	"Periodically check GPU activity for detecting hangs. "

	"WARNING: Disabling this can cause system wide hangs. "

	"(default: true)");



i915_param_named_unsafe(enable_ppgtt, int, 0400);

MODULE_PARM_DESC(enable_ppgtt,

i915_param_named_unsafe(enable_ppgtt, int, 0400,

	"Override PPGTT usage. "

	"(-1=auto [default], 0=disabled, 1=aliasing, 2=full, 3=full with extended address space)");



i915_param_named_unsafe(enable_execlists, int, 0400);

MODULE_PARM_DESC(enable_execlists,

i915_param_named_unsafe(enable_execlists, int, 0400,

	"Override execlists usage. "

	"(-1=auto [default], 0=disabled, 1=enabled)");



i915_param_named_unsafe(enable_psr, int, 0600);

MODULE_PARM_DESC(enable_psr, "Enable PSR "

i915_param_named_unsafe(enable_psr, int, 0600,

	"Enable PSR "

	"(0=disabled, 1=enabled - link mode chosen per-platform, 2=force link-standby mode, 3=force link-off mode) "

	"Default: -1 (use per-chip default)");



i915_param_named_unsafe(alpha_support, bool, 0400);

MODULE_PARM_DESC(alpha_support,

i915_param_named_unsafe(alpha_support, bool, 0400,

	"Enable alpha quality driver support for latest hardware. "

	"See also CONFIG_DRM_I915_ALPHA_SUPPORT.");



i915_param_named_unsafe(disable_power_well, int, 0400);

MODULE_PARM_DESC(disable_power_well,

i915_param_named_unsafe(disable_power_well, int, 0400,

	"Disable display power wells when possible "

	"(-1=auto [default], 0=power wells always on, 1=power wells disabled when possible)");



i915_param_named_unsafe(enable_ips, int, 0600);

MODULE_PARM_DESC(enable_ips, "Enable IPS (default: true)");

i915_param_named_unsafe(enable_ips, int, 0600, "Enable IPS (default: true)");



i915_param_named(fastboot, bool, 0600);

MODULE_PARM_DESC(fastboot,

i915_param_named(fastboot, bool, 0600,

	"Try to skip unnecessary mode sets at boot time (default: false)");



i915_param_named_unsafe(prefault_disable, bool, 0600);

MODULE_PARM_DESC(prefault_disable,

i915_param_named_unsafe(prefault_disable, bool, 0600,

	"Disable page prefaulting for pread/pwrite/reloc (default:false). "

	"For developers only.");



i915_param_named_unsafe(load_detect_test, bool, 0600);

MODULE_PARM_DESC(load_detect_test,

i915_param_named_unsafe(load_detect_test, bool, 0600,

	"Force-enable the VGA load detect code for testing (default:false). "

	"For developers only.");



i915_param_named_unsafe(force_reset_modeset_test, bool, 0600);

MODULE_PARM_DESC(force_reset_modeset_test,

i915_param_named_unsafe(force_reset_modeset_test, bool, 0600,

	"Force a modeset during gpu reset for testing (default:false). "

	"For developers only.");



i915_param_named_unsafe(invert_brightness, int, 0600);

MODULE_PARM_DESC(invert_brightness,

i915_param_named_unsafe(invert_brightness, int, 0600,

	"Invert backlight brightness "

	"(-1 force normal, 0 machine defaults, 1 force inversion), please "

	"report PCI device ID, subsystem vendor and subsystem device ID "

	"to dri-devel@lists.freedesktop.org, if your machine needs it. "

	"It will then be included in an upcoming module version.");



i915_param_named(disable_display, bool, 0400);

MODULE_PARM_DESC(disable_display, "Disable display (default: false)");

i915_param_named(disable_display, bool, 0400,

	"Disable display (default: false)");



i915_param_named_unsafe(enable_cmd_parser, bool, 0400);

MODULE_PARM_DESC(enable_cmd_parser,

i915_param_named_unsafe(enable_cmd_parser, bool, 0400,

	"Enable command parsing (true=enabled [default], false=disabled)");



i915_param_named_unsafe(use_mmio_flip, int, 0600);

MODULE_PARM_DESC(use_mmio_flip,

i915_param_named_unsafe(use_mmio_flip, int, 0600,

	"use MMIO flips (-1=never, 0=driver discretion [default], 1=always)");



i915_param_named(mmio_debug, int, 0600);

MODULE_PARM_DESC(mmio_debug,

i915_param_named(mmio_debug, int, 0600,

	"Enable the MMIO debug code for the first N failures (default: off). "

	"This may negatively affect performance.");



i915_param_named(verbose_state_checks, bool, 0600);

MODULE_PARM_DESC(verbose_state_checks,

i915_param_named(verbose_state_checks, bool, 0600,

	"Enable verbose logs (ie. WARN_ON()) in case of unexpected hw state conditions.");



i915_param_named_unsafe(nuclear_pageflip, bool, 0400);

MODULE_PARM_DESC(nuclear_pageflip,

i915_param_named_unsafe(nuclear_pageflip, bool, 0400,

	"Force enable atomic functionality on platforms that don't have full support yet.");



/* WA to get away with the default setting in VBT for early platforms.Will be removed */

i915_param_named_unsafe(edp_vswing, int, 0400);

MODULE_PARM_DESC(edp_vswing,

i915_param_named_unsafe(edp_vswing, int, 0400,

	"Ignore/Override vswing pre-emph table selection from VBT "

	"(0=use value from vbt [default], 1=low power swing(200mV),"

	"2=default swing(400mV))");



i915_param_named_unsafe(enable_guc_loading, int, 0400);

MODULE_PARM_DESC(enable_guc_loading,

i915_param_named_unsafe(enable_guc_loading, int, 0400,

	"Enable GuC firmware loading "

	"(-1=auto, 0=never [default], 1=if available, 2=required)");



i915_param_named_unsafe(enable_guc_submission, int, 0400);

MODULE_PARM_DESC(enable_guc_submission,

i915_param_named_unsafe(enable_guc_submission, int, 0400,

	"Enable GuC submission "

	"(-1=auto, 0=never [default], 1=if available, 2=required)");



i915_param_named(guc_log_level, int, 0400);

MODULE_PARM_DESC(guc_log_level,

i915_param_named(guc_log_level, int, 0400,

	"GuC firmware logging level (-1:disabled (default), 0-3:enabled)");



i915_param_named_unsafe(guc_firmware_path, charp, 0400);

MODULE_PARM_DESC(guc_firmware_path,

i915_param_named_unsafe(guc_firmware_path, charp, 0400,

	"GuC firmware path to use instead of the default one");



i915_param_named_unsafe(huc_firmware_path, charp, 0400);

MODULE_PARM_DESC(huc_firmware_path,

i915_param_named_unsafe(huc_firmware_path, charp, 0400,

	"HuC firmware path to use instead of the default one");



i915_param_named_unsafe(enable_dp_mst, bool, 0600);

MODULE_PARM_DESC(enable_dp_mst,

i915_param_named_unsafe(enable_dp_mst, bool, 0600,

	"Enable multi-stream transport (MST) for new DisplayPort sinks. (default: true)");

i915_param_named_unsafe(inject_load_failure, uint, 0400);

MODULE_PARM_DESC(inject_load_failure,



i915_param_named_unsafe(inject_load_failure, uint, 0400,

	"Force an error after a number of failure check points (0:disabled (default), N:force failure at the Nth failure check point)");

i915_param_named(enable_dpcd_backlight, bool, 0600);

MODULE_PARM_DESC(enable_dpcd_backlight,



i915_param_named(enable_dpcd_backlight, bool, 0600,

	"Enable support for DPCD backlight control (default:false)");



i915_param_named(enable_gvt, bool, 0400);

MODULE_PARM_DESC(enable_gvt,

i915_param_named(enable_gvt, bool, 0400,

	"Enable support for Intel GVT-g graphics virtualization host support(default:false)");

CRA Git | Maintained and supported by SUSTech CRA and CCSE