Commit 3daf74d7 authored Jun 23, 2012 by Pratyush Anand Committed by Felipe Balbi Jun 25, 2012

usb: dwc3: remove WARN_ON from dwc_stop_active_transfer



Now we are sure that, if res_trans_idx is zero, then endpoint has been
stopped. So it's safe to just return if endpoint is already stopped. No
need to generate warning anymore.

While doing so, it's better to return when res_trans_idx is zero and
decrease one level of indentation.

Signed-off-by: Pratyush Anand <pratyush.anand@st.com>

[ balbi@ti.com: slightly changed commit log ]

Signed-off-by: Felipe Balbi <balbi@ti.com>

parent 58a0f23f

drivers/usb/dwc3/gadget.c

+10 −10

Original line number	Diff line number	Diff line
		@@ -1870,8 +1870,9 @@ static void dwc3_stop_active_transfer(struct dwc3 *dwc, u32 epnum)

		dep = dwc->eps[epnum];

		WARN_ON(!dep->res_trans_idx);
		if (dep->res_trans_idx) {
		if (!dep->res_trans_idx)
		return;

		cmd = DWC3_DEPCMD_ENDTRANSFER;
		cmd \|= DWC3_DEPCMD_HIPRI_FORCERM \| DWC3_DEPCMD_CMDIOC;
		cmd \|= DWC3_DEPCMD_PARAM(dep->res_trans_idx);
		@@ -1880,7 +1881,6 @@ static void dwc3_stop_active_transfer(struct dwc3 *dwc, u32 epnum)
		WARN_ON_ONCE(ret);
		dep->res_trans_idx = 0;
		}
		}

		static void dwc3_stop_active_transfers(struct dwc3 *dwc)
		{

Admin message