Commit 3d9cbe37 authored Jun 11, 2018 by Andy Shevchenko Committed by Dan Williams Dec 10, 2018

libnvdimm, namespace: Replace kmemdup() with kstrndup()



kstrndup() takes care of '\0' terminator for the strings.

Use it here instead of kmemdup() + explicit terminating the input string.

Signed-off-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
Signed-off-by: Dave Jiang <dave.jiang@intel.com>
Signed-off-by: Dan Williams <dan.j.williams@intel.com>

parent 9065ed12

drivers/nvdimm/namespace_devs.c

+1 −2

Original line number	Diff line number	Diff line
		@@ -270,11 +270,10 @@ static ssize_t __alt_name_store(struct device dev, const char buf,
		if (dev->driver \|\| to_ndns(dev)->claim)
		return -EBUSY;

		input = kmemdup(buf, len + 1, GFP_KERNEL);
		input = kstrndup(buf, len, GFP_KERNEL);
		if (!input)
		return -ENOMEM;

		input[len] = '\0';
		pos = strim(input);
		if (strlen(pos) + 1 > NSLABEL_NAME_LEN) {
		rc = -EINVAL;

Admin message