Commit 3d8c11ef authored by Punit Agrawal's avatar Punit Agrawal Committed by Ard Biesheuvel
Browse files

efi: cper: Add support for printing Firmware Error Record Reference 



While debugging a boot failure, the following unknown error record was
seen in the boot logs.

    <...>
    BERT: Error records from previous boot:
    [Hardware Error]: event severity: fatal
    [Hardware Error]:  Error 0, type: fatal
    [Hardware Error]:   section type: unknown, 81212a96-09ed-4996-9471-8d729c8e69ed
    [Hardware Error]:   section length: 0x290
    [Hardware Error]:   00000000: 00000001 00000000 00000000 00020002  ................
    [Hardware Error]:   00000010: 00020002 0000001f 00000320 00000000  ........ .......
    [Hardware Error]:   00000020: 00000000 00000000 00000000 00000000  ................
    [Hardware Error]:   00000030: 00000000 00000000 00000000 00000000  ................
    <...>

On further investigation, it was found that the error record with
UUID (81212a96-09ed-4996-9471-8d729c8e69ed) has been defined in the
UEFI Specification at least since v2.4 and has recently had additional
fields defined in v2.7 Section N.2.10 Firmware Error Record Reference.

Add support for parsing and printing the defined fields to give users
a chance to figure out what went wrong.

Signed-off-by: default avatarPunit Agrawal <punit1.agrawal@toshiba.co.jp>
Cc: Ard Biesheuvel <ardb@kernel.org>
Cc: "Rafael J. Wysocki" <rjw@rjwysocki.net>
Cc: Borislav Petkov <bp@alien8.de>
Cc: James Morse <james.morse@arm.com>
Cc: linux-acpi@vger.kernel.org
Cc: linux-efi@vger.kernel.org
Link: https://lore.kernel.org/r/20200512045502.3810339-1-punit1.agrawal@toshiba.co.jp


Signed-off-by: default avatarArd Biesheuvel <ardb@kernel.org>
parent fd626195

drivers/firmware/efi/cper.c

+62 −0
Original line number Diff line number Diff line
@@ -407,6 +407,58 @@ static void cper_print_pcie(const char *pfx, const struct cper_sec_pcie *pcie, 
	}

}



static const char * const fw_err_rec_type_strs[] = {

	"IPF SAL Error Record",

	"SOC Firmware Error Record Type1 (Legacy CrashLog Support)",

	"SOC Firmware Error Record Type2",

};



static void cper_print_fw_err(const char *pfx,

			      struct acpi_hest_generic_data *gdata,

			      const struct cper_sec_fw_err_rec_ref *fw_err)

{

	void *buf = acpi_hest_get_payload(gdata);

	u32 offset, length = gdata->error_data_length;



	printk("%s""Firmware Error Record Type: %s\n", pfx,

	       fw_err->record_type < ARRAY_SIZE(fw_err_rec_type_strs) ?

	       fw_err_rec_type_strs[fw_err->record_type] : "unknown");

	printk("%s""Revision: %d\n", pfx, fw_err->revision);



	/* Record Type based on UEFI 2.7 */

	if (fw_err->revision == 0) {

		printk("%s""Record Identifier: %08llx\n", pfx,

		       fw_err->record_identifier);

	} else if (fw_err->revision == 2) {

		printk("%s""Record Identifier: %pUl\n", pfx,

		       &fw_err->record_identifier_guid);

	}



	/*

	 * The FW error record may contain trailing data beyond the

	 * structure defined by the specification. As the fields

	 * defined (and hence the offset of any trailing data) vary

	 * with the revision, set the offset to account for this

	 * variation.

	 */

	if (fw_err->revision == 0) {

		/* record_identifier_guid not defined */

		offset = offsetof(struct cper_sec_fw_err_rec_ref,

				  record_identifier_guid);

	} else if (fw_err->revision == 1) {

		/* record_identifier not defined */

		offset = offsetof(struct cper_sec_fw_err_rec_ref,

				  record_identifier);

	} else {

		offset = sizeof(*fw_err);

	}



	buf += offset;

	length -= offset;



	print_hex_dump(pfx, "", DUMP_PREFIX_OFFSET, 16, 4, buf, length, true);

}



static void cper_print_tstamp(const char *pfx,

				   struct acpi_hest_generic_data_v300 *gdata)

{
@@ -494,6 +546,16 @@ cper_estatus_print_section(const char *pfx, struct acpi_hest_generic_data *gdata 
		else

			goto err_section_too_small;

#endif

	} else if (guid_equal(sec_type, &CPER_SEC_FW_ERR_REC_REF)) {

		struct cper_sec_fw_err_rec_ref *fw_err = acpi_hest_get_payload(gdata);



		printk("%ssection_type: Firmware Error Record Reference\n",

		       newpfx);

		/* The minimal FW Error Record contains 16 bytes */

		if (gdata->error_data_length >= SZ_16)

			cper_print_fw_err(newpfx, gdata, fw_err);

		else

			goto err_section_too_small;

	} else {

		const void *err = acpi_hest_get_payload(gdata);

include/linux/cper.h

+9 −0
Original line number Diff line number Diff line
@@ -521,6 +521,15 @@ struct cper_sec_pcie { 
	u8	aer_info[96];

};



/* Firmware Error Record Reference, UEFI v2.7 sec N.2.10  */

struct cper_sec_fw_err_rec_ref {

	u8 record_type;

	u8 revision;

	u8 reserved[6];

	u64 record_identifier;

	guid_t record_identifier_guid;

};



/* Reset to default packing */

#pragma pack()

CRA Git | Maintained and supported by SUSTech CRA and CCSE