Commit 3d8258e4 authored by Sebastian Ott's avatar Sebastian Ott Committed by Martin Schwidefsky
Browse files

s390/pci: move debug messages to debugfs 



The error messages in pci_insn are for debug purposes only. Move
them to the debugfs.

Reviewed-by: default avatarGerald Schaefer <gerald.schaefer@de.ibm.com>
Signed-off-by: default avatarSebastian Ott <sebott@linux.vnet.ibm.com>
Signed-off-by: default avatarMartin Schwidefsky <schwidefsky@de.ibm.com>
parent 24d05ff8

arch/s390/pci/pci_insn.c

+23 −10
Original line number Diff line number Diff line
@@ -8,10 +8,23 @@ 
#include <linux/errno.h>

#include <linux/delay.h>

#include <asm/pci_insn.h>

#include <asm/pci_debug.h>

#include <asm/processor.h>



#define ZPCI_INSN_BUSY_DELAY	1	/* 1 microsecond */



static inline void zpci_err_insn(u8 cc, u8 status, u64 req, u64 offset)

{

	struct {

		u8 cc;

		u8 status;

		u64 req;

		u64 offset;

	} data = {cc, status, req, offset};



	zpci_err_hex(&data, sizeof(data));

}



/* Modify PCI Function Controls */

static inline u8 __mpcifc(u64 req, struct zpci_fib *fib, u8 *status)

{
@@ -38,8 +51,8 @@ int zpci_mod_fc(u64 req, struct zpci_fib *fib) 
	} while (cc == 2);



	if (cc)

		printk_once(KERN_ERR "%s: error cc: %d  status: %d\n",

			     __func__, cc, status);

		zpci_err_insn(cc, status, req, 0);



	return (cc) ? -EIO : 0;

}
@@ -72,8 +85,8 @@ int zpci_refresh_trans(u64 fn, u64 addr, u64 range) 
	} while (cc == 2);



	if (cc)

		printk_once(KERN_ERR "%s: error cc: %d  status: %d  dma_addr: %Lx  size: %Lx\n",

			    __func__, cc, status, addr, range);

		zpci_err_insn(cc, status, addr, range);



	return (cc) ? -EIO : 0;

}
@@ -121,8 +134,8 @@ int zpci_load(u64 *data, u64 req, u64 offset) 
	} while (cc == 2);



	if (cc)

		printk_once(KERN_ERR "%s: error cc: %d  status: %d  req: %Lx  offset: %Lx\n",

			    __func__, cc, status, req, offset);

		zpci_err_insn(cc, status, req, offset);



	return (cc > 0) ? -EIO : cc;

}

EXPORT_SYMBOL_GPL(zpci_load);
@@ -159,8 +172,8 @@ int zpci_store(u64 data, u64 req, u64 offset) 
	} while (cc == 2);



	if (cc)

		printk_once(KERN_ERR "%s: error cc: %d  status: %d  req: %Lx  offset: %Lx\n",

			__func__, cc, status, req, offset);

		zpci_err_insn(cc, status, req, offset);



	return (cc > 0) ? -EIO : cc;

}

EXPORT_SYMBOL_GPL(zpci_store);
@@ -195,8 +208,8 @@ int zpci_store_block(const u64 *data, u64 req, u64 offset) 
	} while (cc == 2);



	if (cc)

		printk_once(KERN_ERR "%s: error cc: %d  status: %d  req: %Lx  offset: %Lx\n",

			    __func__, cc, status, req, offset);

		zpci_err_insn(cc, status, req, offset);



	return (cc > 0) ? -EIO : cc;

}

EXPORT_SYMBOL_GPL(zpci_store_block);

CRA Git | Maintained and supported by SUSTech CRA and CCSE