Commit 3d7d8fc7 authored Nov 20, 2020 by Sean V Kelley Committed by Bjorn Helgaas Dec 04, 2020

PCI/ERR: Avoid negated conditional for clarity

Reverse the sense of the Root Port/Downstream Port conditional for clarity.
No functional change intended.

Link: https://lore.kernel.org/r/20201121001036.8560-9-sean.v.kelley@intel.com

Tested-by: Jonathan Cameron <Jonathan.Cameron@huawei.com> # non-native/no RCEC
Signed-off-by: Sean V Kelley <sean.v.kelley@intel.com>
Signed-off-by: Bjorn Helgaas <bhelgaas@google.com>
Reviewed-by: Kuppuswamy Sathyanarayanan <sathyanarayanan.kuppuswamy@linux.intel.com>
Acked-by: Jonathan Cameron <Jonathan.Cameron@huawei.com>

parent 0791721d

drivers/pci/pcie/err.c

+4 −4

Original line number	Diff line number	Diff line
		@@ -159,11 +159,11 @@ pci_ers_result_t pcie_do_recovery(struct pci_dev *dev,
		* Error recovery runs on all subordinates of the bridge. If the
		* bridge detected the error, it is cleared at the end.
		*/
		if (!(type == PCI_EXP_TYPE_ROOT_PORT \|\|
		type == PCI_EXP_TYPE_DOWNSTREAM))
		bridge = pci_upstream_bridge(dev);
		else
		if (type == PCI_EXP_TYPE_ROOT_PORT \|\|
		type == PCI_EXP_TYPE_DOWNSTREAM)
		bridge = dev;
		else
		bridge = pci_upstream_bridge(dev);

		bus = bridge->subordinate;
		pci_dbg(bridge, "broadcast error_detected message\n");