Commit 3d70fb03 authored Dec 04, 2020 by Zhang Changzhong Committed by Greg Kroah-Hartman Dec 09, 2020

bus: fsl-mc: fix error return code in fsl_mc_object_allocate()

Fix to return a negative error code from the error handling
case instead of 0, as done elsewhere in this function.

Fixes: 197f4d6a ("staging: fsl-mc: fsl-mc object allocator driver")
Reported-by: Hulk Robot <hulkci@huawei.com>
Acked-by: Laurentiu Tudor <laurentiu.tudor@nxp.com>
Signed-off-by: Zhang Changzhong <zhangchangzhong@huawei.com>
Link: https://lore.kernel.org/r/1607068967-31991-1-git-send-email-zhangchangzhong@huawei.com

Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>

parent ca43fec9

drivers/bus/fsl-mc/fsl-mc-allocator.c

+3 −1

Original line number	Diff line number	Diff line
		@@ -292,8 +292,10 @@ int __must_check fsl_mc_object_allocate(struct fsl_mc_device *mc_dev,
		goto error;

		mc_adev = resource->data;
		if (!mc_adev)
		if (!mc_adev) {
		error = -EINVAL;
		goto error;
		}

		mc_adev->consumer_link = device_link_add(&mc_dev->dev,
		&mc_adev->dev,