checkpatch.pl: Suggest lockdep instead of asserting !spin_is_locked() (3d709ab5) · Commits · 戴 / test

This commit points people who might otherwise code up something like WARN_ON(!spin_is_locked(&mylock)) to lockdep_assert_held(&mylock). Signed-off-by:

Paul E. McKenney <paulmck@linux.ibm.com> Cc: Andy Whitcroft <apw@canonical.com> Cc: Joe Perches <joe@perches.com>

scripts/checkpatch.pl

+6 −0

Original line number	Diff line number	Diff line
		@@ -6389,6 +6389,12 @@ sub process {
		"please use device_initcall() or more appropriate function instead of __initcall() (see include/linux/init.h)\n" . $herecurr);
		}

		# check for spin_is_locked(), suggest lockdep instead
		if ($line =~ /\bspin_is_locked\(/) {
		WARN("USE_LOCKDEP",
		"Where possible, use lockdep_assert_held instead of assertions based on spin_is_locked\n" . $herecurr);
		}

		# check for deprecated apis
		if ($line =~ /\b($deprecated_apis_search)\b\s*\(/) {
		my $deprecated_api = $1;

Admin message