Commit 3d6684f4 authored by Rasmus Villemoes's avatar Rasmus Villemoes Committed by Linus Torvalds
Browse files

lib: bitmap: make nbits parameter of bitmap_complement unsigned 



The compiler can generate slightly smaller and simpler code when it
knows that "nbits" is non-negative.  Since no-one passes a negative
bit-count, this shouldn't affect the semantics.

Signed-off-by: default avatarRasmus Villemoes <linux@rasmusvillemoes.dk>
Signed-off-by: default avatarAndrew Morton <akpm@linux-foundation.org>
Signed-off-by: default avatarLinus Torvalds <torvalds@linux-foundation.org>
parent 5e068069

include/linux/bitmap.h

+3 −3
Original line number Diff line number Diff line
@@ -93,7 +93,7 @@ extern int __bitmap_full(const unsigned long *bitmap, unsigned int nbits); 
extern int __bitmap_equal(const unsigned long *bitmap1,

			  const unsigned long *bitmap2, unsigned int nbits);

extern void __bitmap_complement(unsigned long *dst, const unsigned long *src,

			int bits);

			unsigned int nbits);

extern void __bitmap_shift_right(unsigned long *dst,

                        const unsigned long *src, int shift, int bits);

extern void __bitmap_shift_left(unsigned long *dst,
@@ -222,7 +222,7 @@ static inline int bitmap_andnot(unsigned long *dst, const unsigned long *src1, 
}



static inline void bitmap_complement(unsigned long *dst, const unsigned long *src,

			int nbits)

			unsigned int nbits)

{

	if (small_const_nbits(nbits))

		*dst = ~(*src) & BITMAP_LAST_WORD_MASK(nbits);
@@ -231,7 +231,7 @@ static inline void bitmap_complement(unsigned long *dst, const unsigned long *sr 
}



static inline int bitmap_equal(const unsigned long *src1,

			const unsigned long *src2, int nbits)

			const unsigned long *src2, unsigned int nbits)

{

	if (small_const_nbits(nbits))

		return ! ((*src1 ^ *src2) & BITMAP_LAST_WORD_MASK(nbits));

lib/bitmap.c

+2 −2
Original line number Diff line number Diff line
@@ -86,9 +86,9 @@ int __bitmap_equal(const unsigned long *bitmap1, 
}

EXPORT_SYMBOL(__bitmap_equal);



void __bitmap_complement(unsigned long *dst, const unsigned long *src, int bits)

void __bitmap_complement(unsigned long *dst, const unsigned long *src, unsigned int bits)

{

	int k, lim = bits/BITS_PER_LONG;

	unsigned int k, lim = bits/BITS_PER_LONG;

	for (k = 0; k < lim; ++k)

		dst[k] = ~src[k];

CRA Git | Maintained and supported by SUSTech CRA and CCSE