Commit 3d44a6fd authored Nov 14, 2019 by Oliver Neukum Committed by Marcel Holtmann Nov 15, 2019

Bluetooth: btusb: fix PM leak in error case of setup



If setup() fails a reference for runtime PM has already
been taken. Proper use of the error handling in btusb_open()is needed.
You cannot just return.

Fixes: ace31982 ("Bluetooth: btusb: Add setup callback for chip init on USB")
Signed-off-by: Oliver Neukum <oneukum@suse.com>
Signed-off-by: Marcel Holtmann <marcel@holtmann.org>

parent 90bc72b1

drivers/bluetooth/btusb.c

+2 −1

Original line number	Diff line number	Diff line
		@@ -1200,7 +1200,7 @@ static int btusb_open(struct hci_dev *hdev)
		if (data->setup_on_usb) {
		err = data->setup_on_usb(hdev);
		if (err < 0)
		return err;
		goto setup_fail;
		}

		data->intf->needs_remote_wakeup = 1;
		@@ -1239,6 +1239,7 @@ done:

		failed:
		clear_bit(BTUSB_INTR_RUNNING, &data->flags);
		setup_fail:
		usb_autopm_put_interface(data->intf);
		return err;
		}

Admin message