arm/imx/gpio: GPIO_INT_{HIGH,LOW}_LEV are not necessarily constant (3d40f7fe) · Commits · 戴 / test

GPIO_INT_LOW_LEV is defined as (cpu_is_mx1_mx2() ? 0x3 : 0x0) so depending on compiler optimisation and enabled SoCs this doesn't qualify as a constant expression as needed by a switch statement. Ditto for GPIO_INT_HIGH_LEV. Signed-off-by:

Uwe Kleine-König <u.kleine-koenig@pengutronix.de>

arch/arm/plat-mxc/gpio.c

+3 −6

Original line number	Diff line number	Diff line
		@@ -140,16 +140,13 @@ static void mxc_flip_edge(struct mxc_gpio_port *port, u32 gpio)
		val = __raw_readl(reg);
		edge = (val >> (bit << 1)) & 3;
		val &= ~(0x3 << (bit << 1));
		switch (edge) {
		case GPIO_INT_HIGH_LEV:
		if (edge == GPIO_INT_HIGH_LEV) {
		edge = GPIO_INT_LOW_LEV;
		pr_debug("mxc: switch GPIO %d to low trigger\n", gpio);
		break;
		case GPIO_INT_LOW_LEV:
		} else if (edge == GPIO_INT_LOW_LEV) {
		edge = GPIO_INT_HIGH_LEV;
		pr_debug("mxc: switch GPIO %d to high trigger\n", gpio);
		break;
		default:
		} else {
		pr_err("mxc: invalid configuration for GPIO %d: %x\n",
		gpio, edge);
		return;

Admin message