Commit 3d3a126a authored by David Sterba's avatar David Sterba
Browse files

btrfs: remove unused parameter from btrfs_check_super_valid 



None of the checks need to know the ro/rw status as they're all not
changing the superblock. Moreover, we can access the sb flags directly
if we'd need to decide by the ro/rw status.

Reviewed-by: default avatarLiu Bo <bo.li.liu@oracle.com>
Signed-off-by: default avatarDavid Sterba <dsterba@suse.com>
parent 8b74c03e

fs/btrfs/disk-io.c

+3 −5
Original line number Diff line number Diff line
@@ -64,8 +64,7 @@ 
static const struct extent_io_ops btree_extent_io_ops;

static void end_workqueue_fn(struct btrfs_work *work);

static void free_fs_root(struct btrfs_root *root);

static int btrfs_check_super_valid(struct btrfs_fs_info *fs_info,

				    int read_only);

static int btrfs_check_super_valid(struct btrfs_fs_info *fs_info);

static void btrfs_destroy_ordered_extents(struct btrfs_root *root);

static int btrfs_destroy_delayed_refs(struct btrfs_transaction *trans,

				      struct btrfs_fs_info *fs_info);
@@ -2801,7 +2800,7 @@ int open_ctree(struct super_block *sb, 


	memcpy(fs_info->fsid, fs_info->super_copy->fsid, BTRFS_FSID_SIZE);



	ret = btrfs_check_super_valid(fs_info, sb->s_flags & MS_RDONLY);

	ret = btrfs_check_super_valid(fs_info);

	if (ret) {

		btrfs_err(fs_info, "superblock contains fatal errors");

		err = -EINVAL;
@@ -4115,8 +4114,7 @@ int btrfs_read_buffer(struct extent_buffer *buf, u64 parent_transid) 
	return btree_read_extent_buffer_pages(fs_info, buf, parent_transid);

}



static int btrfs_check_super_valid(struct btrfs_fs_info *fs_info,

			      int read_only)

static int btrfs_check_super_valid(struct btrfs_fs_info *fs_info)

{

	struct btrfs_super_block *sb = fs_info->super_copy;

	u64 nodesize = btrfs_super_nodesize(sb);

CRA Git | Maintained and supported by SUSTech CRA and CCSE