Commit 3d267f24 authored Sep 11, 2013 by Jean Delvare Committed by Linus Torvalds Sep 11, 2013

firmware/dmi_scan: drop obsolete comment



This comment predates the introduction of early_ioremap.  Since then the
missing calls to dmi_iounmap have been added by Ingo and Yinghai in
commits 0d64484f ("x86: fix DMI ioremap leak") and 3212bff3
("x86: left over fix for leak of early_ioremp in dmi_scan") .  That was
over 5 years ago so it is about time to drop this now misleading
comment.

Signed-off-by: Jean Delvare <jdelvare@suse.de>
Cc: Ingo Molnar <mingo@kernel.org>
Cc: Yinghai Lu <yinghai@kernel.org>
Cc: Joe Perches <joe@perches.com>
Cc: Ben Hutchings <ben@decadent.org.uk>
Signed-off-by: Andrew Morton <akpm@linux-foundation.org>
Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org>

parent 91cf5ab6

drivers/firmware/dmi_scan.c

+0 −5

Original line number	Diff line number	Diff line
		@@ -504,11 +504,6 @@ void __init dmi_scan_machine(void)
		}
		}
		else {
		/*
		* no iounmap() for that ioremap(); it would be a no-op, but
		* it's so early in setup that sucker gets confused into doing
		* what it shouldn't if we actually call it.
		*/
		p = dmi_ioremap(0xF0000, 0x10000);
		if (p == NULL)
		goto error;

Admin message