Commit 3d2557ab authored Aug 04, 2019 by Nishka Dasgupta Committed by Krzysztof Kozlowski Oct 01, 2019

pinctrl: samsung: Add of_node_put() before return in error path



Each iteration of for_each_child_of_node puts the previous node, but in
the case of a return from the middle of the loop, there is no put, thus
causing a memory leak. Hence add an of_node_put before the return of
exynos_eint_wkup_init() error path.
Issue found with Coccinelle.

Signed-off-by: Nishka Dasgupta <nishkadg.linux@gmail.com>
Cc: <stable@vger.kernel.org>
Fixes: 14c255d3 ("pinctrl: exynos: Add irq_chip instance for Exynos7 wakeup interrupts")
Signed-off-by: Krzysztof Kozlowski <krzk@kernel.org>

parent 54ecb8f7

drivers/pinctrl/samsung/pinctrl-exynos.c

+3 −1

Original line number	Diff line number	Diff line
		@@ -486,8 +486,10 @@ int exynos_eint_wkup_init(struct samsung_pinctrl_drv_data *d)
		if (match) {
		irq_chip = kmemdup(match->data,
		sizeof(*irq_chip), GFP_KERNEL);
		if (!irq_chip)
		if (!irq_chip) {
		of_node_put(np);
		return -ENOMEM;
		}
		wkup_np = np;
		break;
		}

Admin message