Commit 3d2257f1 authored Sep 12, 2009 by David Woodhouse Committed by Jens Axboe Sep 14, 2009

Make DISCARD_BARRIER and DISCARD_NOBARRIER writes instead of reads



The commands are conceptually writes, and in the case of IDE and SCSI
commands actually are writes.  They were only reads because we thought
that would interact better with the elevators.  Now the elevators know
about discard requests, that advantage no longer exists.

Signed-off-by: David Woodhouse <David.Woodhouse@intel.com>
Signed-off-by: Matthew Wilcox <willy@linux.intel.com>
Signed-off-by: Jens Axboe <jens.axboe@oracle.com>

parent b8a9ae77

include/linux/fs.h

+2 −2

Original line number	Diff line number	Diff line
		@@ -161,8 +161,8 @@ struct inodes_stat_t {
		* These aren't really reads or writes, they pass down information about
		* parts of device that are now unused by the file system.
		*/
		#define DISCARD_NOBARRIER (1 << BIO_RW_DISCARD)
		#define DISCARD_BARRIER ((1 << BIO_RW_DISCARD) \| (1 << BIO_RW_BARRIER))
		#define DISCARD_NOBARRIER (WRITE \| (1 << BIO_RW_DISCARD))
		#define DISCARD_BARRIER (DISCARD_NOBARRIER \| (1 << BIO_RW_BARRIER))

		#define SEL_IN 1
		#define SEL_OUT 2

Admin message