Commit 3ce711a6 authored Sep 19, 2012 by Markus Trippelsdorf Committed by Arnaldo Carvalho de Melo Sep 24, 2012

perf tools: bfd.h/libbfd detection fails with recent binutils

With recent binutils I get:

 perf % make
Makefile:668: No bfd.h/libbfd found, install binutils-dev[el]/zlib-static to gain symbol demanglin

That happens because bfd.h now contains:

I've reopened a bug in the hope that this check will be deleted:
http://sourceware.org/bugzilla/show_bug.cgi?id=14243



But in the meantime, the following patch fixes the problem

Signed-off-by: Markus Trippelsdorf <markus@trippelsdorf.de>
Cc: Ingo Molnar <mingo@redhat.com>
Cc: Mike Frysinger <vapier@gentoo.org>
Cc: Paul Mackerras <paulus@samba.org>
Link: http://lkml.kernel.org/r/20120919072902.GA262@x4


Signed-off-by: Arnaldo Carvalho de Melo <acme@redhat.com>

parent 70d93044

tools/perf/Makefile

+1 −1

Original line number	Diff line number	Diff line
		@@ -715,7 +715,7 @@ else
		EXTLIBS += -liberty
		BASIC_CFLAGS += -DHAVE_CPLUS_DEMANGLE
		else
		FLAGS_BFD=$(ALL_CFLAGS) $(ALL_LDFLAGS) $(EXTLIBS) -lbfd
		FLAGS_BFD=$(ALL_CFLAGS) $(ALL_LDFLAGS) $(EXTLIBS) -DPACKAGE='perf' -lbfd
		has_bfd := $(call try-cc,$(SOURCE_BFD),$(FLAGS_BFD))
		ifeq ($(has_bfd),y)
		EXTLIBS += -lbfd

tools/perf/util/symbol.h

+1 −0

Original line number	Diff line number	Diff line
		@@ -34,6 +34,7 @@ static inline char bfd_demangle(void __maybe_unused v,
		return NULL;
		}
		#else
		#define PACKAGE 'perf'
		#include <bfd.h>
		#endif
		#endif

Admin message