Commit 3cdc8db9 authored Oct 17, 2019 by Arnaldo Carvalho de Melo

perf trace: Show error message when not finding a field used in a filter expression

It was there, but as pr_debug(), make it pr_err() so that we can see it
without -v:

  # trace -e syscalls:*lseek --filter="whenc==SET" sleep 1
  "whenc" not found in "syscalls:sys_enter_lseek", can't set filter "whenc==SET"
  #

Cc: Adrian Hunter <adrian.hunter@intel.com>
Cc: David Ahern <dsahern@gmail.com>
Cc: Jiri Olsa <jolsa@kernel.org>
Cc: Luis Cláudio Gonçalves <lclaudio@redhat.com>
Cc: Namhyung Kim <namhyung@kernel.org>
Link: https://lkml.kernel.org/n/tip-ly4rgm1bto8uwc2itpaixjob@git.kernel.org


Signed-off-by: Arnaldo Carvalho de Melo <acme@redhat.com>

parent df604bfd

tools/perf/builtin-trace.c

+2 −2

Original line number	Diff line number	Diff line
		@@ -3611,7 +3611,7 @@ static int trace__expand_filter(struct trace *trace __maybe_unused, struct evsel

		fmt = perf_evsel__syscall_arg_fmt(evsel, arg);
		if (fmt == NULL) {
		pr_debug("\"%s\" not found in \"%s\", can't set filter \"%s\"\n",
		pr_err("\"%s\" not found in \"%s\", can't set filter \"%s\"\n",
		arg, evsel->name, evsel->filter);
		return -1;
		}

Admin message