Commit 3cdc409c authored Mar 25, 2006 by Adrian Bunk Committed by Linus Torvalds Mar 25, 2006

[PATCH] reiserfs/xattr_acl.c:reiserfs_get_acl(): make size an int



The Coverity checker wasn't happy seeing a size_t compared with -ENODATA
and -ENOSYS.

Since the only place where size is set is through the result of
reiserfs_xattr_get() which is an int, we could simply make size an int.

Signed-off-by: Adrian Bunk <bunk@stusta.de>
Cc: Jeff Mahoney <jeffm@suse.com>
Cc: Chris Mason <mason@suse.com>
Cc: Hans Reiser <reiser@namesys.com>
Signed-off-by: Andrew Morton <akpm@osdl.org>
Signed-off-by: Linus Torvalds <torvalds@osdl.org>

parent 340e48e6

fs/reiserfs/xattr_acl.c

+2 −2

Original line number	Diff line number	Diff line
		@@ -182,7 +182,7 @@ struct posix_acl reiserfs_get_acl(struct inode inode, int type)
		{
		char name, value;
		struct posix_acl acl, *p_acl;
		size_t size;
		int size;
		int retval;
		struct reiserfs_inode_info *reiserfs_i = REISERFS_I(inode);

		@@ -206,7 +206,7 @@ struct posix_acl reiserfs_get_acl(struct inode inode, int type)
		return posix_acl_dup(*p_acl);

		size = reiserfs_xattr_get(inode, name, NULL, 0);
		if ((int)size < 0) {
		if (size < 0) {
		if (size == -ENODATA \|\| size == -ENOSYS) {
		*p_acl = ERR_PTR(-ENODATA);
		return NULL;

Admin message