Commit 3cd3a86b authored Oct 12, 2007 by Adrian Hunter Committed by David Woodhouse Oct 14, 2007

[MTD] [OneNAND] Avoid deadlock in erase callback; release chip lock first.



When the erase callback performs some other action on the flash, it's
highly likely to deadlock unless we actually release the chip lock
before calling it.

This patch mirrors that same change already done for NAND.

Signed-off-by: Adrian Hunter <ext-adrian.hunter@nokia.com>
Signed-off-by: David Woodhouse <dwmw2@infradead.org>

parent 30a7eb29

drivers/mtd/onenand/onenand_base.c

+4 −3

Original line number	Diff line number	Diff line
		@@ -1711,13 +1711,14 @@ static int onenand_erase(struct mtd_info mtd, struct erase_info instr)
		erase_exit:

		ret = instr->state == MTD_ERASE_DONE ? 0 : -EIO;
		/* Do call back function */
		if (!ret)
		mtd_erase_callback(instr);

		/* Deselect and wake up anyone waiting on the device */
		onenand_release_device(mtd);

		/* Do call back function */
		if (!ret)
		mtd_erase_callback(instr);

		return ret;
		}

Admin message