rcu: Move rcu_expedited and rcu_normal externs from rcupdate.h (3caec62f) · Commits · 戴 / test

The rcu_expedited and rcu_normal variables are used only by sysctl and kernel/rcu/update.c, so it does not make sense to their extern declarations in rcupdate.h. This commit therefore moves these extern declarations to update.c. Reported-by:

Ingo Molnar <mingo@kernel.org> Signed-off-by:

Paul E. McKenney <paulmck@linux.vnet.ibm.com>

include/linux/rcupdate.h

+0 −7

Original line number	Diff line number	Diff line
		@@ -46,13 +46,6 @@
		#include <linux/ktime.h>
		#include <linux/irqflags.h>

		#include <asm/barrier.h>

		#ifndef CONFIG_TINY_RCU
		extern int rcu_expedited; /* for sysctl */
		extern int rcu_normal; /* also for sysctl */
		#endif /* #ifndef CONFIG_TINY_RCU */

		#ifdef CONFIG_TINY_RCU
		/* Tiny RCU doesn't expedite, as its purpose in life is instead to be tiny. */
		static inline bool rcu_gp_is_normal(void) /* Internal RCU use. */

kernel/rcu/update.c

+2 −0

Original line number	Diff line number	Diff line
		@@ -62,7 +62,9 @@
		#define MODULE_PARAM_PREFIX "rcupdate."

		#ifndef CONFIG_TINY_RCU
		extern int rcu_expedited; /* from sysctl */
		module_param(rcu_expedited, int, 0);
		extern int rcu_normal; /* from sysctl */
		module_param(rcu_normal, int, 0);
		static int rcu_normal_after_boot;
		module_param(rcu_normal_after_boot, int, 0);

Admin message