sctp: remove rcu_read_lock from sctp_bind_addr_state (3cab2afb) · Commits · 戴 / test

sctp_bind_addr_state() is called either in packet rcv path or by sctp_copy_local_addr_list(), which are under rcu_read_lock. So there's no need to call it again in sctp_bind_addr_state(). Signed-off-by:

Xin Long <lucien.xin@gmail.com> Signed-off-by:

David S. Miller <davem@davemloft.net>

net/sctp/bind_addr.c

+4 −9

Original line number	Diff line number	Diff line
		@@ -393,24 +393,19 @@ int sctp_bind_addr_state(const struct sctp_bind_addr *bp,
		{
		struct sctp_sockaddr_entry *laddr;
		struct sctp_af *af;
		int state = -1;

		af = sctp_get_af_specific(addr->sa.sa_family);
		if (unlikely(!af))
		return state;
		return -1;

		rcu_read_lock();
		list_for_each_entry_rcu(laddr, &bp->address_list, list) {
		if (!laddr->valid)
		continue;
		if (af->cmp_addr(&laddr->a, addr)) {
		state = laddr->state;
		break;
		if (af->cmp_addr(&laddr->a, addr))
		return laddr->state;
		}
		}
		rcu_read_unlock();

		return state;
		return -1;
		}

		/* Find the first address in the bind address list that is not present in

Admin message