Commit 3ca121c2 authored Aug 26, 2017 by Dan Carpenter Committed by Greg Kroah-Hartman Aug 28, 2017

staging: lustre: obdclass: return -EFAULT if copy_to_user() fails



We recently changed from using obd_ioctl_popdata() to calling
copy_to_user() directly.  This if statement was supposed to be deleted
but it was over looked.  "err" is zero at this point so it means we
return success.

Fixes: b03679f6 ("staging: lustre: uapi: remove obd_ioctl_popdata() wrapper")
Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>

parent 9c8e28df

drivers/staging/lustre/lustre/obdclass/class_obd.c

+0 −1

Original line number	Diff line number	Diff line
		@@ -262,7 +262,6 @@ int class_handle_ioctl(unsigned int cmd, unsigned long arg)
		dev);

		if (copy_to_user((void __user )arg, data, sizeof(data)))
		if (err)
		err = -EFAULT;
		goto out;
		}

Admin message