Commit 3c9d903b authored by Jitendra Bhivare's avatar Jitendra Bhivare Committed by Martin K. Petersen
Browse files

be2iscsi: Added return value check for mgmt_get_all_if_id 



Use of mutex_lock_interruptible can return -EINTR, handle and log the
error.

Signed-off-by: default avatarJitendra Bhivare <jitendra.bhivare@avagotech.com>
Reviewed-by: default avatarHannes Reinecke <hare@suse.com>
Signed-off-by: default avatarMartin K. Petersen <martin.petersen@oracle.com>
parent 9ec6f6b8

drivers/scsi/be2iscsi/be_iscsi.c

+4 −3
Original line number Diff line number Diff line
@@ -367,13 +367,14 @@ beiscsi_set_vlan_tag(struct Scsi_Host *shost, 
		      struct iscsi_iface_param_info *iface_param)

{

	struct beiscsi_hba *phba = iscsi_host_priv(shost);

	int ret = 0;

	int ret;



	/* Get the Interface Handle */

	if (mgmt_get_all_if_id(phba)) {

	ret = mgmt_get_all_if_id(phba);

	if (ret) {

		beiscsi_log(phba, KERN_ERR, BEISCSI_LOG_CONFIG,

			    "BS_%d : Getting Interface Handle Failed\n");

		return -EIO;

		return ret;

	}



	switch (iface_param->param) {

drivers/scsi/be2iscsi/be_mgmt.c

+6 −4
Original line number Diff line number Diff line
@@ -1025,8 +1025,9 @@ int mgmt_set_ip(struct beiscsi_hba *phba, 
	uint32_t ip_type;

	int rc;



	if (mgmt_get_all_if_id(phba))

		return -EIO;

	rc = mgmt_get_all_if_id(phba);

	if (rc)

		return rc;



	ip_type = (ip_param->param == ISCSI_NET_PARAM_IPV6_ADDR) ?

		BE2_IPV6 : BE2_IPV4 ;
@@ -1195,8 +1196,9 @@ int mgmt_get_if_info(struct beiscsi_hba *phba, int ip_type, 
	uint32_t ioctl_size = sizeof(struct be_cmd_get_if_info_resp);

	int rc;



	if (mgmt_get_all_if_id(phba))

		return -EIO;

	rc = mgmt_get_all_if_id(phba);

	if (rc)

		return rc;



	do {

		rc = mgmt_alloc_cmd_data(phba, &nonemb_cmd,

CRA Git | Maintained and supported by SUSTech CRA and CCSE