Commit 3c9855f6 authored by Ville Syrjälä's avatar Ville Syrjälä Committed by Daniel Vetter
Browse files

drm: Add drm_rotation_simplify() 



drm_rotation_simplify() can be used to eliminate unsupported rotation
flags. It will check if any unsupported flags are present, and if so
it will modify the rotation to an alternate form by adding 180 degrees
to rotation angle, and flipping the reflect x and y bits. The hope is
that this identity transform will eliminate the unsupported flags.

Of course that might not result in any more supported rotation, so
the caller is still responsible for checking the result afterwards.

Cc: dri-devel@lists.freedesktop.org
Signed-off-by: default avatarVille Syrjälä <ville.syrjala@linux.intel.com>
Reviewed-by: default avatarImre Deak <imre.deak@intel.com>
Acked-by: default avatarDave Airlie <airlied@linux.ie>
Signed-off-by: default avatarDaniel Vetter <daniel.vetter@ffwll.ch>
parent 07074006

drivers/gpu/drm/drm_crtc.c

+30 −0
Original line number Diff line number Diff line
@@ -4841,6 +4841,36 @@ int drm_format_vert_chroma_subsampling(uint32_t format) 
}

EXPORT_SYMBOL(drm_format_vert_chroma_subsampling);



/**

 * drm_rotation_simplify() - Try to simplify the rotation

 * @rotation: Rotation to be simplified

 * @supported_rotations: Supported rotations

 *

 * Attempt to simplify the rotation to a form that is supported.

 * Eg. if the hardware supports everything except DRM_REFLECT_X

 * one could call this function like this:

 *

 * drm_rotation_simplify(rotation, BIT(DRM_ROTATE_0) |

 *                       BIT(DRM_ROTATE_90) | BIT(DRM_ROTATE_180) |

 *                       BIT(DRM_ROTATE_270) | BIT(DRM_REFLECT_Y));

 *

 * to eliminate the DRM_ROTATE_X flag. Depending on what kind of

 * transforms the hardware supports, this function may not

 * be able to produce a supported transform, so the caller should

 * check the result afterwards.

 */

unsigned int drm_rotation_simplify(unsigned int rotation,

				   unsigned int supported_rotations)

{

	if (rotation & ~supported_rotations) {

		rotation ^= BIT(DRM_REFLECT_X) | BIT(DRM_REFLECT_Y);

		rotation = (rotation & ~0xf) | BIT((ffs(rotation & 0xf) + 1) % 4);

	}



	return rotation;

}

EXPORT_SYMBOL(drm_rotation_simplify);



/**

 * drm_mode_config_init - initialize DRM mode_configuration structure

 * @dev: DRM device

include/drm/drm_crtc.h

+2 −0
Original line number Diff line number Diff line
@@ -1115,6 +1115,8 @@ extern int drm_format_vert_chroma_subsampling(uint32_t format); 
extern const char *drm_get_format_name(uint32_t format);

extern struct drm_property *drm_mode_create_rotation_property(struct drm_device *dev,

							      unsigned int supported_rotations);

extern unsigned int drm_rotation_simplify(unsigned int rotation,

					  unsigned int supported_rotations);



/* Helpers */

CRA Git | Maintained and supported by SUSTech CRA and CCSE