Commit 3c76cd84 authored by Miao Xie's avatar Miao Xie Committed by Josef Bacik
Browse files

Btrfs: allocate new chunks if the space is not enough for global rsv 



When running the 208th of xfstests, the fs returned the enospc
error when there was lots of free space in the disk.

By bisect debug, we found it was introduced by commit 96f1bb57.
This commit makes the space check for the global reservation in
can_overcommit() be inconsistent with should_alloc_chunk().
can_overcommit() requires that the free space is 2 times the size
of the global reservation, or we can't do overcommit. And instead,
we need reclaim some reserved space, and if we still don't have
enough free space, we need allocate a new chunk. But unfortunately,
should_alloc_chunk() just requires that the free space is 1 time
the size of the global reservation, that is we would not try to
allocate a new chunk if the free space size is in the middle of
these two requires, and just return the enospc error. Fix it.

Cc: Jim Schutt <jaschut@sandia.gov>
Cc: Josef Bacik <jbacik@fusionio.com>
Signed-off-by: default avatarMiao Xie <miaox@cn.fujitsu.com>
Signed-off-by: default avatarJosef Bacik <jbacik@fusionio.com>
parent fc36ed7e

fs/btrfs/extent-tree.c

+11 −8
Original line number Diff line number Diff line
@@ -3673,6 +3673,11 @@ static void force_metadata_allocation(struct btrfs_fs_info *info) 
	rcu_read_unlock();

}



static inline u64 calc_global_rsv_need_space(struct btrfs_block_rsv *global)

{

	return (global->size << 1);

}



static int should_alloc_chunk(struct btrfs_root *root,

			      struct btrfs_space_info *sinfo, int force)

{
@@ -3690,7 +3695,7 @@ static int should_alloc_chunk(struct btrfs_root *root, 
	 * global_rsv, it doesn't change except when the transaction commits.

	 */

	if (sinfo->flags & BTRFS_BLOCK_GROUP_METADATA)

		num_allocated += global_rsv->size;

		num_allocated += calc_global_rsv_need_space(global_rsv);



	/*

	 * in limited mode, we want to have some free space up to
@@ -3862,7 +3867,7 @@ static int can_overcommit(struct btrfs_root *root, 
{

	struct btrfs_block_rsv *global_rsv = &root->fs_info->global_block_rsv;

	u64 profile = btrfs_get_alloc_profile(root, 0);

	u64 rsv_size = 0;

	u64 space_size;

	u64 avail;

	u64 used;

	u64 to_add;
@@ -3870,18 +3875,16 @@ static int can_overcommit(struct btrfs_root *root, 
	used = space_info->bytes_used + space_info->bytes_reserved +

		space_info->bytes_pinned + space_info->bytes_readonly;



	spin_lock(&global_rsv->lock);

	rsv_size = global_rsv->size;

	spin_unlock(&global_rsv->lock);



	/*

	 * We only want to allow over committing if we have lots of actual space

	 * free, but if we don't have enough space to handle the global reserve

	 * space then we could end up having a real enospc problem when trying

	 * to allocate a chunk or some other such important allocation.

	 */

	rsv_size <<= 1;

	if (used + rsv_size >= space_info->total_bytes)

	spin_lock(&global_rsv->lock);

	space_size = calc_global_rsv_need_space(global_rsv);

	spin_unlock(&global_rsv->lock);

	if (used + space_size >= space_info->total_bytes)

		return 0;



	used += space_info->bytes_may_use;

CRA Git | Maintained and supported by SUSTech CRA and CCSE