Commit 3c73a2dd authored by Linus Torvalds's avatar Linus Torvalds
Browse files

Merge tag 'spi-fix-v4.4-rc5' of git://git.kernel.org/pub/scm/linux/kernel/git/broonie/spi 

Pull spi fixes from Mark Brown:
 "A couple of reference counting bugs here, one in spidev and one with
  holding an extra reference in the core that we never freed if we
  removed a device, plus a driver specific fix.  Both of the refcounting
  bugs are very old but they've only been found by observation so
  hopefully their impact has been low"

* tag 'spi-fix-v4.4-rc5' of git://git.kernel.org/pub/scm/linux/kernel/git/broonie/spi:
  spi: fix parent-device reference leak
  spi: spidev: Hold spi_lock over all defererences of spi in release()
  spi-fsl-dspi: Fix CTAR Register access
parents d525c13e c1f4a149

drivers/spi/spi-fsl-dspi.c

+6 −6
Original line number Diff line number Diff line
@@ -167,7 +167,7 @@ static inline int is_double_byte_mode(struct fsl_dspi *dspi) 
{

	unsigned int val;



	regmap_read(dspi->regmap, SPI_CTAR(dspi->cs), &val);

	regmap_read(dspi->regmap, SPI_CTAR(0), &val);



	return ((val & SPI_FRAME_BITS_MASK) == SPI_FRAME_BITS(8)) ? 0 : 1;

}
@@ -257,7 +257,7 @@ static u32 dspi_data_to_pushr(struct fsl_dspi *dspi, int tx_word) 


	return	SPI_PUSHR_TXDATA(d16) |

		SPI_PUSHR_PCS(dspi->cs) |

		SPI_PUSHR_CTAS(dspi->cs) |

		SPI_PUSHR_CTAS(0) |

		SPI_PUSHR_CONT;

}
@@ -290,7 +290,7 @@ static int dspi_eoq_write(struct fsl_dspi *dspi) 
		 */

		if (tx_word && (dspi->len == 1)) {

			dspi->dataflags |= TRAN_STATE_WORD_ODD_NUM;

			regmap_update_bits(dspi->regmap, SPI_CTAR(dspi->cs),

			regmap_update_bits(dspi->regmap, SPI_CTAR(0),

					SPI_FRAME_BITS_MASK, SPI_FRAME_BITS(8));

			tx_word = 0;

		}
@@ -339,7 +339,7 @@ static int dspi_tcfq_write(struct fsl_dspi *dspi) 


	if (tx_word && (dspi->len == 1)) {

		dspi->dataflags |= TRAN_STATE_WORD_ODD_NUM;

		regmap_update_bits(dspi->regmap, SPI_CTAR(dspi->cs),

		regmap_update_bits(dspi->regmap, SPI_CTAR(0),

				SPI_FRAME_BITS_MASK, SPI_FRAME_BITS(8));

		tx_word = 0;

	}
@@ -407,7 +407,7 @@ static int dspi_transfer_one_message(struct spi_master *master, 
		regmap_update_bits(dspi->regmap, SPI_MCR,

				SPI_MCR_CLR_TXF | SPI_MCR_CLR_RXF,

				SPI_MCR_CLR_TXF | SPI_MCR_CLR_RXF);

		regmap_write(dspi->regmap, SPI_CTAR(dspi->cs),

		regmap_write(dspi->regmap, SPI_CTAR(0),

				dspi->cur_chip->ctar_val);



		trans_mode = dspi->devtype_data->trans_mode;
@@ -566,7 +566,7 @@ static irqreturn_t dspi_interrupt(int irq, void *dev_id) 
		if (!dspi->len) {

			if (dspi->dataflags & TRAN_STATE_WORD_ODD_NUM) {

				regmap_update_bits(dspi->regmap,

						   SPI_CTAR(dspi->cs),

						   SPI_CTAR(0),

						   SPI_FRAME_BITS_MASK,

						   SPI_FRAME_BITS(16));

				dspi->dataflags &= ~TRAN_STATE_WORD_ODD_NUM;

drivers/spi/spi.c

+1 −1
Original line number Diff line number Diff line
@@ -1705,7 +1705,7 @@ struct spi_master *spi_alloc_master(struct device *dev, unsigned size) 
	master->bus_num = -1;

	master->num_chipselect = 1;

	master->dev.class = &spi_master_class;

	master->dev.parent = get_device(dev);

	master->dev.parent = dev;

	spi_master_set_devdata(master, &master[1]);



	return master;

drivers/spi/spidev.c

+1 −1
Original line number Diff line number Diff line
@@ -651,11 +651,11 @@ static int spidev_release(struct inode *inode, struct file *filp) 
		kfree(spidev->rx_buffer);

		spidev->rx_buffer = NULL;



		spin_lock_irq(&spidev->spi_lock);

		if (spidev->spi)

			spidev->speed_hz = spidev->spi->max_speed_hz;



		/* ... after we unbound from the underlying device? */

		spin_lock_irq(&spidev->spi_lock);

		dofree = (spidev->spi == NULL);

		spin_unlock_irq(&spidev->spi_lock);

CRA Git | Maintained and supported by SUSTech CRA and CCSE