serdev: ttyport: call tiocmget and tiocmset ops directly (3c635e4f) · Commits · 戴 / test

The tty struct holds a pointer to the driver's tty operations so drop the unnecessary driver dereference when calling tiocmget and tiocmset. Note that this also makes the calls match the preceding sanity checks as expected. Signed-off-by:

Johan Hovold <johan@kernel.org> Signed-off-by:

Greg Kroah-Hartman <gregkh@linuxfoundation.org>

drivers/tty/serdev/serdev-ttyport.c

+2 −2

Original line number	Diff line number	Diff line
		@@ -233,7 +233,7 @@ static int ttyport_get_tiocm(struct serdev_controller *ctrl)
		if (!tty->ops->tiocmget)
		return -ENOTSUPP;

		return tty->driver->ops->tiocmget(tty);
		return tty->ops->tiocmget(tty);
		}

		static int ttyport_set_tiocm(struct serdev_controller *ctrl, unsigned int set, unsigned int clear)
		@@ -244,7 +244,7 @@ static int ttyport_set_tiocm(struct serdev_controller *ctrl, unsigned int set, u
		if (!tty->ops->tiocmset)
		return -ENOTSUPP;

		return tty->driver->ops->tiocmset(tty, set, clear);
		return tty->ops->tiocmset(tty, set, clear);
		}

		static const struct serdev_controller_ops ctrl_ops = {

Admin message