Commit 3c454145 authored Jun 05, 2015 by Chao Yu Committed by Jaegeuk Kim Jun 11, 2015

f2fs: do not trim preallocated blocks when truncating after i_size



When we perform generic/092 in xfstests, output is like below:

     XXX Bytes, X ops; XX:XX:XX.X (XXX YYY/sec and XXX ops/sec)
     0: [0..10239]: data
     0: [0..10239]: data
    -1: [10240..20479]: unwritten
    +1: [10240..14335]: unwritten

This is because with this testcase, we redefine the regulation for
truncate in perallocated space past i_size as below:

"There was some confused about what the fs was supposed to do when you
truncate at i_size with preallocated space past i_size. We decided on the
following things.

1) truncate(i_size) will trim all blocks past i_size.
2) truncate(x) where x > i_size will not trim all blocks past i_size.
"

This method is used in xfs, and then ext4/btrfs will follow the rule.

This patch fixes to follow the new rule for f2fs.

Signed-off-by: Chao Yu <chao2.yu@samsung.com>
Signed-off-by: Jaegeuk Kim <jaegeuk@kernel.org>

parent 43f54cd5

fs/f2fs/file.c

+4 −4

Original line number	Diff line number	Diff line
		@@ -651,16 +651,16 @@ int f2fs_setattr(struct dentry dentry, struct iattr attr)
		f2fs_get_encryption_info(inode))
		return -EACCES;

		if (attr->ia_size != i_size_read(inode)) {
		if (attr->ia_size <= i_size_read(inode)) {
		truncate_setsize(inode, attr->ia_size);
		f2fs_truncate(inode);
		f2fs_balance_fs(F2FS_I_SB(inode));
		} else {
		/*
		* giving a chance to truncate blocks past EOF which
		* are fallocated with FALLOC_FL_KEEP_SIZE.
		* do not trim all blocks after i_size if target size is
		* larger than i_size.
		*/
		f2fs_truncate(inode);
		truncate_setsize(inode, attr->ia_size);
		}
		}

Admin message