Commit 3c3c6f66 authored by Jason Yan's avatar Jason Yan Committed by Martin K. Petersen
Browse files

scsi: megaraid: make some symbols static in megaraid_sas_fp.c 

Fix the following sparse warning:

drivers/scsi/megaraid/megaraid_sas_fp.c:88:5: warning: symbol
'mega_div64_32' was not declared. Should it be static?
drivers/scsi/megaraid/megaraid_sas_fp.c:370:5: warning: symbol
'MR_GetSpanBlock' was not declared. Should it be static?
drivers/scsi/megaraid/megaraid_sas_fp.c:420:5: warning: symbol
'mr_spanset_get_span_block' was not declared. Should it be static?
drivers/scsi/megaraid/megaraid_sas_fp.c:645:4: warning: symbol 'get_arm'
was not declared. Should it be static?
drivers/scsi/megaraid/megaraid_sas_fp.c:788:4: warning: symbol
'MR_GetPhyParams' was not declared. Should it be static?
drivers/scsi/megaraid/megaraid_sas_fp.c:1345:4: warning: symbol
'megasas_get_best_arm_pd' was not declared. Should it be static?

Link: https://lore.kernel.org/r/20200407092827.18074-3-yanaijie@huawei.com


Reported-by: default avatarHulk Robot <hulkci@huawei.com>
Signed-off-by: default avatarJason Yan <yanaijie@huawei.com>
Signed-off-by: default avatarMartin K. Petersen <martin.petersen@oracle.com>
parent 02ff1070

drivers/scsi/megaraid/megaraid_sas_fp.c

+6 −6
Original line number Diff line number Diff line
@@ -85,7 +85,7 @@ u32 mega_mod64(u64 dividend, u32 divisor) 
 *

 * @return quotient

 **/

u64 mega_div64_32(uint64_t dividend, uint32_t divisor)

static u64 mega_div64_32(uint64_t dividend, uint32_t divisor)

{

	u32 remainder;

	u64 d;
@@ -367,7 +367,7 @@ u8 MR_ValidateMapInfo(struct megasas_instance *instance, u64 map_id) 
	return 1;

}



u32 MR_GetSpanBlock(u32 ld, u64 row, u64 *span_blk,

static u32 MR_GetSpanBlock(u32 ld, u64 row, u64 *span_blk,

		    struct MR_DRV_RAID_MAP_ALL *map)

{

	struct MR_SPAN_BLOCK_INFO *pSpanBlock = MR_LdSpanInfoGet(ld, map);
@@ -417,7 +417,7 @@ u32 MR_GetSpanBlock(u32 ld, u64 row, u64 *span_blk, 
*    div_error	   - Devide error code.

*/



u32 mr_spanset_get_span_block(struct megasas_instance *instance,

static u32 mr_spanset_get_span_block(struct megasas_instance *instance,

		u32 ld, u64 row, u64 *span_blk, struct MR_DRV_RAID_MAP_ALL *map)

{

	struct fusion_context *fusion = instance->ctrl_context;
@@ -642,7 +642,7 @@ static u32 get_arm_from_strip(struct megasas_instance *instance, 
}



/* This Function will return Phys arm */

u8 get_arm(struct megasas_instance *instance, u32 ld, u8 span, u64 stripe,

static u8 get_arm(struct megasas_instance *instance, u32 ld, u8 span, u64 stripe,

		struct MR_DRV_RAID_MAP_ALL *map)

{

	struct MR_LD_RAID  *raid = MR_LdRaidGet(ld, map);
@@ -785,7 +785,7 @@ static u8 mr_spanset_get_phy_params(struct megasas_instance *instance, u32 ld, 
*    span          - Span number

*    block         - Absolute Block number in the physical disk

*/

u8 MR_GetPhyParams(struct megasas_instance *instance, u32 ld, u64 stripRow,

static u8 MR_GetPhyParams(struct megasas_instance *instance, u32 ld, u64 stripRow,

		u16 stripRef, struct IO_REQUEST_INFO *io_info,

		struct RAID_CONTEXT *pRAID_Context,

		struct MR_DRV_RAID_MAP_ALL *map)
@@ -1342,7 +1342,7 @@ void mr_update_load_balance_params(struct MR_DRV_RAID_MAP_ALL *drv_map, 
	}

}



u8 megasas_get_best_arm_pd(struct megasas_instance *instance,

static u8 megasas_get_best_arm_pd(struct megasas_instance *instance,

			   struct LD_LOAD_BALANCE_INFO *lbInfo,

			   struct IO_REQUEST_INFO *io_info,

			   struct MR_DRV_RAID_MAP_ALL *drv_map)

CRA Git | Maintained and supported by SUSTech CRA and CCSE