Commit 3c2760b7 authored Feb 25, 2020 by Xu Yilun Committed by Moritz Fischer Mar 30, 2020

fpga: dfl: pci: fix return value of cci_pci_sriov_configure



pci_driver.sriov_configure should return negative value on error and
number of enabled VFs on success. But now the driver returns 0 on
success. The sriov configure still works but will cause a warning
message:

  XX VFs requested; only 0 enabled

This patch changes the return value accordingly.

Cc: stable@vger.kernel.org
Signed-off-by: Xu Yilun <yilun.xu@intel.com>
Signed-off-by: Wu Hao <hao.wu@intel.com>
Signed-off-by: Moritz Fischer <mdf@kernel.org>

parent daec0f4a

drivers/fpga/dfl-pci.c

+4 −2

Original line number	Diff line number	Diff line
		@@ -248,11 +248,13 @@ static int cci_pci_sriov_configure(struct pci_dev *pcidev, int num_vfs)
		return ret;

		ret = pci_enable_sriov(pcidev, num_vfs);
		if (ret)
		if (ret) {
		dfl_fpga_cdev_config_ports_pf(cdev);
		return ret;
		}
		}

		return ret;
		return num_vfs;
		}

		static void cci_pci_remove(struct pci_dev *pcidev)

Admin message