Commit 3c05c4be authored Aug 17, 2011 by Stefano Stabellini Committed by Konrad Rzeszutek Wilk Aug 22, 2011

xen: Do not enable PV IPIs when vector callback not present

Fix regression for HVM case on older (<4.1.1) hypervisors caused by

  commit 99bbb3a8
  Author: Stefano Stabellini <stefano.stabellini@eu.citrix.com>
  Date:   Thu Dec 2 17:55:10 2010 +0000

    xen: PV on HVM: support PV spinlocks and IPIs

This change replaced the SMP operations with event based handlers without
taking into account that this only works when the hypervisor supports
callback vectors. This causes unexplainable hangs early on boot for
HVM guests with more than one CPU.

BugLink: http://bugs.launchpad.net/bugs/791850



CC: stable@kernel.org
Signed-off-by: Stefan Bader <stefan.bader@canonical.com>
Signed-off-by: Stefano Stabellini <stefano.stabellini@eu.citrix.com>
Tested-and-Reported-by: Stefan Bader <stefan.bader@canonical.com>
Signed-off-by: Konrad Rzeszutek Wilk <konrad.wilk@oracle.com>

parent ccbcdf7c

arch/x86/xen/smp.c

+2 −2

Original line number	Diff line number	Diff line
		@@ -521,8 +521,6 @@ static void __init xen_hvm_smp_prepare_cpus(unsigned int max_cpus)
		native_smp_prepare_cpus(max_cpus);
		WARN_ON(xen_smp_intr_init(0));

		if (!xen_have_vector_callback)
		return;
		xen_init_lock_cpu(0);
		xen_init_spinlocks();
		}
		@@ -546,6 +544,8 @@ static void xen_hvm_cpu_die(unsigned int cpu)

		void __init xen_hvm_smp_init(void)
		{
		if (!xen_have_vector_callback)
		return;
		smp_ops.smp_prepare_cpus = xen_hvm_smp_prepare_cpus;
		smp_ops.smp_send_reschedule = xen_smp_send_reschedule;
		smp_ops.cpu_up = xen_hvm_cpu_up;

Admin message