Commit 3bd07ccd authored Feb 20, 2018 by Joe Moriarty Committed by Daniel Vetter Mar 06, 2018

drm: NULL pointer dereference [null-pointer-deref] (CWE 476) problem



The Parfait (version 2.1.0) static code analysis tool found the
following NULL pointer dereference problem.

- drivers/gpu/drm/drm_drv.c
Any calls to drm_minor_get_slot() could result in the return of a NULL
pointer when an invalid DRM device type is encountered.  The
return of NULL was removed with BUG() from drm_minor_get_slot().

Signed-off-by: Joe Moriarty <joe.moriarty@oracle.com>
Reviewed-by: Steven Sistare <steven.sistare@oracle.com>
Signed-off-by: Daniel Vetter <daniel.vetter@ffwll.ch>
Link: https://patchwork.freedesktop.org/patch/msgid/20180220191157.100960-3-joe.moriarty@oracle.com

parent 4ffb8dee

drivers/gpu/drm/drm_drv.c

+1 −1

Original line number	Diff line number	Diff line
		@@ -99,7 +99,7 @@ static struct drm_minor *drm_minor_get_slot(struct drm_device dev,
		case DRM_MINOR_CONTROL:
		return &dev->control;
		default:
		return NULL;
		BUG();
		}
		}

Admin message