ASoC: amd: ACP needs to be powered off in BIOS. (3bc7b6c1) · Commits · 戴 / test

Removed this logic because It is BIOS which needs to power off the ACP power domian through ACP_PGFSM_CTRL register when you De-initialize ACP Engine. Signed-off-by:

Ravulapati Vishnu vardhan rao <Vishnuvardhanrao.Ravulapati@amd.com> Link: https://lore.kernel.org/r/1581935964-15059-1-git-send-email-Vishnuvardhanrao.Ravulapati@amd.com Signed-off-by:

Mark Brown <broonie@kernel.org>

sound/soc/amd/raven/pci-acp3x.c

+0 −23

Original line number	Diff line number	Diff line
		@@ -45,23 +45,6 @@ static int acp3x_power_on(void __iomem *acp3x_base)
		return -ETIMEDOUT;
		}

		static int acp3x_power_off(void __iomem *acp3x_base)
		{
		u32 val;
		int timeout;

		rv_writel(ACP_PGFSM_CNTL_POWER_OFF_MASK,
		acp3x_base + mmACP_PGFSM_CONTROL);
		timeout = 0;
		while (++timeout < 500) {
		val = rv_readl(acp3x_base + mmACP_PGFSM_STATUS);
		if ((val & ACP_PGFSM_STATUS_MASK) == ACP_POWERED_OFF)
		return 0;
		udelay(1);
		}
		return -ETIMEDOUT;
		}

		static int acp3x_reset(void __iomem *acp3x_base)
		{
		u32 val;
		@@ -115,12 +98,6 @@ static int acp3x_deinit(void __iomem *acp3x_base)
		pr_err("ACP3x reset failed\n");
		return ret;
		}
		/* power off */
		ret = acp3x_power_off(acp3x_base);
		if (ret) {
		pr_err("ACP3x power off failed\n");
		return ret;
		}
		return 0;
		}

Admin message