Commit 3bbb24b2 authored Mar 06, 2014 by Josef Bacik Committed by Chris Mason Mar 20, 2014

Btrfs: fix deadlock with nested trans handles



Zach found this deadlock that would happen like this

btrfs_end_transaction <- reduce trans->use_count to 0
  btrfs_run_delayed_refs
    btrfs_cow_block
      find_free_extent
	btrfs_start_transaction <- increase trans->use_count to 1
          allocate chunk
	btrfs_end_transaction <- decrease trans->use_count to 0
	  btrfs_run_delayed_refs
	    lock tree block we are cowing above ^^

We need to only decrease trans->use_count if it is above 1, otherwise leave it
alone.  This will make nested trans be the only ones who decrease their added
ref, and will let us get rid of the trans->use_count++ hack if we have to commit
the transaction.  Thanks,

cc: stable@vger.kernel.org
Reported-by: Zach Brown <zab@redhat.com>
Signed-off-by: Josef Bacik <jbacik@fb.com>
Tested-by: Zach Brown <zab@redhat.com>
Signed-off-by: Chris Mason <clm@fb.com>

parent 573bfb72

fs/btrfs/transaction.c

+4 −10

Original line number	Diff line number	Diff line
		@@ -683,7 +683,8 @@ static int __btrfs_end_transaction(struct btrfs_trans_handle *trans,
		int lock = (trans->type != TRANS_JOIN_NOLOCK);
		int err = 0;

		if (--trans->use_count) {
		if (trans->use_count > 1) {
		trans->use_count--;
		trans->block_rsv = trans->orig_rsv;
		return 0;
		}
		@@ -731,18 +732,11 @@ static int __btrfs_end_transaction(struct btrfs_trans_handle *trans,
		}

		if (lock && ACCESS_ONCE(cur_trans->state) == TRANS_STATE_BLOCKED) {
		if (throttle) {
		/*
		* We may race with somebody else here so end up having
		* to call end_transaction on ourselves again, so inc
		* our use_count.
		*/
		trans->use_count++;
		if (throttle)
		return btrfs_commit_transaction(trans, root);
		} else {
		else
		wake_up_process(info->transaction_kthread);
		}
		}

		if (trans->type & __TRANS_FREEZABLE)
		sb_end_intwrite(root->fs_info->sb);

Admin message