drm/st7586: Remove sending of vblank event (3bace4f9) · Commits · 戴 / test

The atomic helpers automatically send out fake VBLANK events if no vblanking has been initialized. Remove the sending code from the driver. v4: * separate commit from core vblank changes Signed-off-by:

Thomas Zimmermann <tzimmermann@suse.de> Acked-by:

Gerd Hoffmann <kraxel@redhat.com> Reviewed-by:

Daniel Vetter <daniel.vetter@ffwll.ch> Link: https://patchwork.freedesktop.org/patch/msgid/20200129120531.6891-12-tzimmermann@suse.de

drivers/gpu/drm/tiny/st7586.c

+0 −9

Original line number	Diff line number	Diff line
		@@ -23,7 +23,6 @@
		#include <drm/drm_gem_framebuffer_helper.h>
		#include <drm/drm_mipi_dbi.h>
		#include <drm/drm_rect.h>
		#include <drm/drm_vblank.h>

		/* controller-specific commands */
		#define ST7586_DISP_MODE_GRAY 0x38
		@@ -159,18 +158,10 @@ static void st7586_pipe_update(struct drm_simple_display_pipe *pipe,
		struct drm_plane_state *old_state)
		{
		struct drm_plane_state *state = pipe->plane.state;
		struct drm_crtc *crtc = &pipe->crtc;
		struct drm_rect rect;

		if (drm_atomic_helper_damage_merged(old_state, state, &rect))
		st7586_fb_dirty(state->fb, &rect);

		if (crtc->state->event) {
		spin_lock_irq(&crtc->dev->event_lock);
		drm_crtc_send_vblank_event(crtc, crtc->state->event);
		spin_unlock_irq(&crtc->dev->event_lock);
		crtc->state->event = NULL;
		}
		}

		static void st7586_pipe_enable(struct drm_simple_display_pipe *pipe,

Admin message