Commit 3ba7ab22 authored Jan 09, 2017 by Michal Hocko Committed by David Sterba Feb 14, 2017

btrfs: fix up misleading GFP_NOFS usage in btrfs_releasepage



b335b003 ("Btrfs: Avoid using __GFP_HIGHMEM with slab allocator")
has reduced the allocation mask in btrfs_releasepage to GFP_NOFS just
to prevent from giving an unappropriate gfp mask to the slab allocator
deeper down the callchain (in alloc_extent_state). This is wrong for
two reasons a) GFP_NOFS might be just too restrictive for the calling
context b) it is better to tweak the gfp mask down when it needs that.

So just remove the mask tweaking from btrfs_releasepage and move it
down to alloc_extent_state where it is needed.

Signed-off-by: Michal Hocko <mhocko@suse.com>
Reviewed-by: David Sterba <dsterba@suse.com>
Signed-off-by: David Sterba <dsterba@suse.com>

parent 18dc22c1

fs/btrfs/extent_io.c

+5 −0

Original line number	Diff line number	Diff line
		@@ -226,6 +226,11 @@ static struct extent_state *alloc_extent_state(gfp_t mask)
		{
		struct extent_state *state;

		/*
		* The given mask might be not appropriate for the slab allocator,
		* drop the unsupported bits
		*/
		mask &= ~(__GFP_DMA32\|__GFP_HIGHMEM);
		state = kmem_cache_alloc(extent_state_cache, mask);
		if (!state)
		return state;

fs/btrfs/inode.c

+1 −1

Original line number	Diff line number	Diff line
		@@ -8831,7 +8831,7 @@ static int btrfs_releasepage(struct page *page, gfp_t gfp_flags)
		{
		if (PageWriteback(page) \|\| PageDirty(page))
		return 0;
		return __btrfs_releasepage(page, gfp_flags & GFP_NOFS);
		return __btrfs_releasepage(page, gfp_flags);
		}

		static void btrfs_invalidatepage(struct page *page, unsigned int offset,

Admin message