Commit 3ba76256 authored Jan 20, 2020 by Jun Li Committed by Greg Kroah-Hartman Jan 22, 2020

usb: typec: tcpci: mask event interrupts when remove driver



This is to prevent any possible events generated while unregister
tpcm port.

Fixes: 74e656d6 ("staging: typec: Type-C Port Controller Interface driver (tcpci)")
Signed-off-by: Li Jun <jun.li@nxp.com>
Reviewed-by: Heikki Krogerus <heikki.krogerus@linux.intel.com>
Reviewed-by: Guenter Roeck <linux@roeck-us.net>
Link: https://lore.kernel.org/r/1579502333-4145-1-git-send-email-jun.li@nxp.com


Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>

parent e1f236ef

drivers/usb/typec/tcpm/tcpci.c

+6 −0

Original line number	Diff line number	Diff line
		@@ -591,6 +591,12 @@ static int tcpci_probe(struct i2c_client *client,
		static int tcpci_remove(struct i2c_client *client)
		{
		struct tcpci_chip *chip = i2c_get_clientdata(client);
		int err;

		/* Disable chip interrupts before unregistering port */
		err = tcpci_write16(chip->tcpci, TCPC_ALERT_MASK, 0);
		if (err < 0)
		return err;

		tcpci_unregister_port(chip->tcpci);

Admin message