Commit 3ba52ad5 authored by luanshi's avatar luanshi Committed by Will Deacon
Browse files

drivers/perf: arm_pmu_acpi: Fix incorrect checking of gicc pointer



Fix bogus NULL checks on the return value of acpi_cpu_get_madt_gicc()
by checking for a 0 'gicc->performance_interrupt' value instead.

Signed-off-by: default avatarLiguang Zhang <zhangliguang@linux.alibaba.com>
Signed-off-by: default avatarWill Deacon <will@kernel.org>
parent 049d9191
Loading
Loading
Loading
Loading
+2 −5
Original line number Diff line number Diff line
@@ -24,8 +24,6 @@ static int arm_pmu_acpi_register_irq(int cpu)
	int gsi, trigger;

	gicc = acpi_cpu_get_madt_gicc(cpu);
	if (WARN_ON(!gicc))
		return -EINVAL;

	gsi = gicc->performance_interrupt;

@@ -64,10 +62,9 @@ static void arm_pmu_acpi_unregister_irq(int cpu)
	int gsi;

	gicc = acpi_cpu_get_madt_gicc(cpu);
	if (!gicc)
		return;

	gsi = gicc->performance_interrupt;
	if (gsi)
		acpi_unregister_gsi(gsi);
}