Commit 3b9c9f3b authored by YueHaibing's avatar YueHaibing Committed by David S. Miller
Browse files

net: rose: add missing dev_put() on error in rose_bind 



when capable check failed, dev_put should
be call before return -EACCES.

Signed-off-by: default avatarYueHaibing <yuehaibing@huawei.com>
Signed-off-by: default avatarDavid S. Miller <davem@davemloft.net>
parent a968b5e9

net/rose/af_rose.c

+3 −1
Original line number Diff line number Diff line
@@ -689,8 +689,10 @@ static int rose_bind(struct socket *sock, struct sockaddr *uaddr, int addr_len) 
		rose->source_call = user->call;

		ax25_uid_put(user);

	} else {

		if (ax25_uid_policy && !capable(CAP_NET_BIND_SERVICE))

		if (ax25_uid_policy && !capable(CAP_NET_BIND_SERVICE)) {

			dev_put(dev);

			return -EACCES;

		}

		rose->source_call   = *source;

	}

CRA Git | Maintained and supported by SUSTech CRA and CCSE